Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added global index to partition_table test #11651

Open
wants to merge 13 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
dm: handle the query in metadata from binlog (#11743)
close #11735
  • Loading branch information
joccau authored and mjonss committed Nov 25, 2024
commit 94082c3c5d1eb580075999053fa475904bf596f1
3 changes: 2 additions & 1 deletion dm/pkg/dumpling/utils.go
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,8 @@ func ParseMetaDataByReader(filename string, rd io.Reader) (*binlog.Location, *bi
}

switch line {
case "SHOW MASTER STATUS:":
case "SHOW BINARY LOG STATUS:",
"SHOW MASTER STATUS:":
if err3 := parsePosAndGTID(&pos, &gtidStr); err3 != nil {
return nil, nil, err3
}
Expand Down
23 changes: 23 additions & 0 deletions dm/pkg/dumpling/utils_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -84,6 +84,29 @@ Finished dump at: 2018-12-27 19:51:22`,
mysql.Position{},
"",
},
{
`Started dump at: 2018-12-27 19:51:22
SHOW BINARY LOG STATUS:
Log: mysql-bin.000004
Pos: 3295818
GTID:

SHOW SLAVE STATUS:
Host: 10.128.27.98
Log: mysql-bin.000003
Pos: 329635
GTID:

Finished dump at: 2018-12-27 19:51:22`,
mysql.Position{
Name: "mysql-bin.000004",
Pos: 3295818,
},
"",
false,
mysql.Position{},
"",
},
{ // with empty line after multiple GTID sets
`Started dump at: 2020-05-21 18:14:49
SHOW MASTER STATUS:
Expand Down