dm: handle the query in metadata from binlog #11743
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: joccau <zak.zhao@pingcap.cn>
ti-chi-bot
bot
added
do-not-merge/needs-linked-issue
release-note
|
|
ti-chi-bot
bot
added
size/XS
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files
Flags with carried forward coverage won't be shown. Click here to find out more. @@ Coverage Diff @@
## master #11743 +/- ##
================================================
+ Coverage 55.1510% 55.2136% +0.0626%
================================================
Files 1002 1002
Lines 137399 137580 +181
================================================
+ Hits 75777 75963 +186
- Misses 56074 56081 +7
+ Partials 5548 5536 -12
|
Signed-off-by: joccau <zak.zhao@pingcap.cn>
ti-chi-bot
bot
added
size/S
joccau
changed the title
joccau
changed the title
ti-chi-bot
bot
added
release-note-none
ti-chi-bot
bot
added
needs-1-more-lgtm
lance6716
approved these changes
Nov 21, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: GMHDBJD, lance6716 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ti-chi-bot
bot
added
lgtm
and removed
needs-1-more-lgtm
|
@joccau please sign CLA |
Done |
|
/retest |
1 similar comment
|
/retest |
mjonss
pushed a commit
to mjonss/tiflow
that referenced
this pull request
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #11735
What is changed and how it works?
Handle the new format of binlog metadata from mariadb to read the binlog position.
Check List
Tests
Questions
Will it cause performance regression or break compatibility?
Not.
Do you need to update user documentation, design documentation or monitoring documentation?
Not.
Release note