Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sink(ticdc): Add output-old-value config (#10915) #10964

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #10915

What problem does this PR solve?

Issue Number: close #10916

What is changed and how it works?

this Add sink.open.output-old-value for open protocol, sink.debezium.output-old-value for debezium protocol, the default value is true.

Open Protocol Events behavior detail

If sink.open.output-old-value is true, no difference
If sink.open.output-old-value is false

  • Add
    No impact
{
"u": [{"c1": xxx}],
"p": null,
"d": null
}
  • Update
    The p will be null
{
"u": [{"c1": xxx}],
"p": null,
"d": null
}
  • Delete
    No impact
{
"d": [{"c1": xxx}],
"p": null,
"u": null
}

Debezium protocol behavior

If sink.debezium.output-old-value is true, no difference
If sink.debezium.output-old-value is false

  • Add
    No impact
  • Update
    The before fields is null
  {
    "before": null,
    "after": {
        "id": 111,
        "name": "scooter",
        "description": "Big 2-wheel scooter",
        "weight": 5.15
        },
    "source": {...},
    "op": "u",
    "ts_ms": 1589362330904 ,
    "transaction": null
    };
  • Delete
    No impact

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note

Add `sink.open.output-old-value`  for open protocol,  `sink.debezium.output-old-value` for debezium protocol to control weather output the old value to downstream.

@ti-chi-bot ti-chi-bot added affect-ticdc-config-docs Pull requests that affect TiCDC configuration docs. lgtm release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. type/cherry-pick-for-release-8.1 This PR is cherry-picked to release-8.1 from a source PR. labels Apr 24, 2024
Copy link
Contributor

ti-chi-bot bot commented Apr 24, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sdojjy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Apr 24, 2024
Copy link

codecov bot commented Apr 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (release-8.1@3582359). Click here to learn what that means.

Additional details and impacted files
Components Coverage Δ
cdc 61.7278% <0.0000%> (?)
dm 51.2454% <0.0000%> (?)
engine 63.4020% <0.0000%> (?)
Flag Coverage Δ
unit 57.4175% <100.0000%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

@@               Coverage Diff                @@
##             release-8.1     #10964   +/-   ##
================================================
  Coverage               ?   57.4175%           
================================================
  Files                  ?        849           
  Lines                  ?     125075           
  Branches               ?          0           
================================================
  Hits                   ?      71815           
  Misses                 ?      47870           
  Partials               ?       5390           

@sdojjy
Copy link
Member

sdojjy commented Apr 24, 2024

/retest-required

2 similar comments
@sdojjy
Copy link
Member

sdojjy commented Apr 24, 2024

/retest-required

@sdojjy
Copy link
Member

sdojjy commented Apr 25, 2024

/retest-required

@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Apr 25, 2024
@sdojjy
Copy link
Member

sdojjy commented Apr 25, 2024

/hold

@ti-chi-bot ti-chi-bot bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 25, 2024
@sdojjy
Copy link
Member

sdojjy commented Apr 25, 2024

/unhold

@ti-chi-bot ti-chi-bot bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 25, 2024
@ti-chi-bot ti-chi-bot removed the cherry-pick-approved Cherry pick PR approved by release team. label Apr 26, 2024
@sdojjy
Copy link
Member

sdojjy commented Apr 27, 2024

/retest-required

@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Apr 28, 2024
@sdojjy
Copy link
Member

sdojjy commented Apr 28, 2024

/retest-required

@ti-chi-bot ti-chi-bot bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 28, 2024
@ti-chi-bot ti-chi-bot bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 28, 2024
@sdojjy
Copy link
Member

sdojjy commented Apr 28, 2024

/retest-required

@ti-chi-bot ti-chi-bot bot merged commit 1eed6c0 into pingcap:release-8.1 Apr 28, 2024
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
affect-ticdc-config-docs Pull requests that affect TiCDC configuration docs. approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. type/cherry-pick-for-release-8.1 This PR is cherry-picked to release-8.1 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants