Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort ssts by their first key when IngestSST in raftstore v2 #7748

Merged
merged 1 commit into from
Jul 5, 2023

Conversation

CalvinNeo
Copy link
Member

@CalvinNeo CalvinNeo commented Jul 5, 2023

What problem does this PR solve?

Issue Number: ref #4982 close #7720

Problem Summary:
update proxy to raftstore-proxy
Proxy PR:
Including:\nSubmodule contrib/tiflash-proxy 653568e1c3...bc0ebe45a0:

Sort if meet multiple cf files in one round of handle_ingest_sst (#339)
Add helper to examine SST file (#338)
diagnostic: fix index out of bounds error in sysinfo (#333)
Add debug utils for tablet snapshot (#331)
Support replace url with a host string (#337)
< fff
< ff
< u
< l
< z2
< z

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

Signed-off-by: CalvinNeo <calvinneo1995@gmail.com>
@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 5, 2023
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Jul 5, 2023
@JaySon-Huang
Copy link
Contributor

/hold

I see this PR is to sort the SSTs in one IngestSST command by their first key. This may not handle the situation that multiple SST files' key range could be overlap.

@ti-chi-bot ti-chi-bot bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 5, 2023
@CalvinNeo
Copy link
Member Author

CalvinNeo commented Jul 5, 2023

@JaySon-Huang There are multiple IngestSST requests in one RaftCmd, one IngestSST contains one sst file to be ingested.

It is confirmed that in one RaftCmd, sst ranges will not overlap, which means the following case won't happen

A [a..c)
B [b..d)

Overlap can happen in different Raft Cmds, like the following

A [a..b) 
B [b..c)
C [c..d]

The first Raft Cmd contains A/C, and the next one contains B

@CalvinNeo CalvinNeo changed the title update proxy of master to raftstore-proxy Sort ssts by their first key when IngestSST in raftstore v2 Jul 5, 2023
@JaySon-Huang
Copy link
Contributor

/unhold

@ti-chi-bot ti-chi-bot bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 5, 2023
@JaySon-Huang
Copy link
Contributor

/approve

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jul 5, 2023

@JaySon-Huang: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

  • Currently the CI jobs are not prow job style, we need it to notify Jenkins server to run them.
  • If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@CalvinNeo
Copy link
Member Author

/merge

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jul 5, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JaySon-Huang, lidezhu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [JaySon-Huang,lidezhu]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jul 5, 2023
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jul 5, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-07-05 08:37:45.137443056 +0000 UTC m=+193097.071076468: ☑️ agreed by lidezhu.
  • 2023-07-05 11:10:24.753346103 +0000 UTC m=+202256.686979524: ☑️ agreed by JaySon-Huang.

@ti-chi-bot ti-chi-bot bot merged commit 53c5beb into pingcap:master Jul 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Dynamic Region] Tiflash crash when br import
3 participants