-
Notifications
You must be signed in to change notification settings - Fork 409
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sort ssts by their first key when IngestSST in raftstore v2 #7748
Sort ssts by their first key when IngestSST in raftstore v2 #7748
Conversation
Signed-off-by: CalvinNeo <calvinneo1995@gmail.com>
/hold I see this PR is to sort the SSTs in one IngestSST command by their first key. This may not handle the situation that multiple SST files' key range could be overlap. |
@JaySon-Huang There are multiple IngestSST requests in one RaftCmd, one IngestSST contains one sst file to be ingested. It is confirmed that in one RaftCmd, sst ranges will not overlap, which means the following case won't happen
Overlap can happen in different Raft Cmds, like the following
The first Raft Cmd contains A/C, and the next one contains B |
/unhold |
/approve |
@JaySon-Huang: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
/merge |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JaySon-Huang, lidezhu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
What problem does this PR solve?
Issue Number: ref #4982 close #7720
Problem Summary:
update proxy to raftstore-proxy
Proxy PR:
Including:\nSubmodule contrib/tiflash-proxy 653568e1c3...bc0ebe45a0:
What is changed and how it works?
Check List
Tests
Side effects
Documentation
Release note