Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix config parser and reformat #337

Merged
merged 2 commits into from
Dec 3, 2019
Merged

Fix config parser and reformat #337

merged 2 commits into from
Dec 3, 2019

Conversation

solotzg
Copy link
Contributor

@solotzg solotzg commented Dec 3, 2019

No description provided.

@solotzg
Copy link
Contributor Author

solotzg commented Dec 3, 2019

/run-integration-tests

@solotzg
Copy link
Contributor Author

solotzg commented Dec 3, 2019

PTAL @zanmato1984

@solotzg
Copy link
Contributor Author

solotzg commented Dec 3, 2019

/run-integration-tests

zanmato1984
zanmato1984 approved these changes Dec 3, 2019
View reviewed changes
Copy link
Contributor

@zanmato1984 zanmato1984 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@solotzg
Copy link
Contributor Author

solotzg commented Dec 3, 2019

/run-integration-tests

@solotzg solotzg changed the title Fix and reformat config Fix config parser and reformat Dec 3, 2019
@solotzg solotzg merged commit 62442e4 into pingcap:master Dec 3, 2019
@solotzg solotzg deleted the optimize-fix branch December 3, 2019 08:48
This was referenced Jun 29, 2023
Merged
Closed
Merged
Open
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zanmato1984 zanmato1984 zanmato1984 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@solotzg @zanmato1984