Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add DB config max_threads by grpc context #4795

Merged

Conversation

mengxin9014
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #4794

Problem Summary:

What is changed and how it works?

If set max_threads, it will be pushed down to TiFlash by grpc context to make DB context in a session.

set max_threads =

  • -1 : TiFlash will use its own max_threads config;
  • 0 : max_threads will be pushed down to TiFlash and it means that the concurrency will determined automatically;
  • x(>0) : max_threads will be pushed down to TiFlash and it means that the concurrency will be set to x.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Release note

add DB config max_threads by grpc context.

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Apr 28, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • LittleFall
  • windtalker

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Apr 28, 2022
@mengxin9014 mengxin9014 self-assigned this Apr 28, 2022
@ti-chi-bot ti-chi-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Apr 28, 2022
@mengxin9014 mengxin9014 changed the title add DB config max_threads by grpc context WIP: add DB config max_threads by grpc context Apr 28, 2022
@ti-chi-bot ti-chi-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 28, 2022
Copy link
Contributor

@windtalker windtalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label May 6, 2022
@mengxin9014
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

@mengxin9014: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

@mengxin9014: /merge in this pull request requires 2 approval(s).

In response to this:

/merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@mengxin9014 mengxin9014 changed the title WIP: add DB config max_threads by grpc context add DB config max_threads by grpc context May 13, 2022
@ti-chi-bot ti-chi-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 13, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels May 13, 2022
@mengxin9014
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

@mengxin9014: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: a94aeed

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label May 13, 2022
@sre-bot
Copy link
Collaborator

sre-bot commented May 13, 2022

Coverage for changed files

too many lines from llvm-cov, please refer to full report instead

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
18121      9785             46.00%    202195  97854        51.60%

full coverage report (for internal network access only)

@ti-chi-bot ti-chi-bot merged commit c0d2d56 into pingcap:master May 13, 2022
@mengxin9014 mengxin9014 deleted the mx/addDbConfigMaxThreadsByGrpcContext branch December 30, 2022 06:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adding mysql variable max_threads for TiFlash.
5 participants