Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding mysql variable max_threads for TiFlash. #4794

Closed
mengxin9014 opened this issue Apr 28, 2022 · 3 comments · Fixed by #4795
Closed

Adding mysql variable max_threads for TiFlash. #4794

mengxin9014 opened this issue Apr 28, 2022 · 3 comments · Fixed by #4795
Assignees
Labels
type/enhancement The issue or PR belongs to an enhancement.

Comments

@mengxin9014
Copy link
Contributor

Enhancement

Need adding mysql variable max_threads for TiFlash.

Now if we want change max_threads in TiFlash, we need modify TiFlash config and restart TiFlash.
So we add mysql variable max_threads that we can just set max_threads in TiDB client to make the param go into effect in a session immediately.

@mengxin9014 mengxin9014 added the type/enhancement The issue or PR belongs to an enhancement. label Apr 28, 2022
@mengxin9014 mengxin9014 self-assigned this Apr 28, 2022
@JaySon-Huang
Copy link
Contributor

... and restart TiFlash

actually, we don't need to restart TiFlash after changing max_threads in the config file. It will be automatically reload once the config file is changed.

global_context->setConfigReloadCallback([&]() {
main_config_reloader->reload();
users_config_reloader->reload();
});

@mengxin9014
Copy link
Contributor Author

... and restart TiFlash

actually, we don't need to restart TiFlash after changing max_threads in the config file. It will be automatically reload once the config file is changed.

global_context->setConfigReloadCallback([&]() {
main_config_reloader->reload();
users_config_reloader->reload();
});

Maybe it needs to update the config file on each node.
Detailed requirement is here: https://pingcap.feishu.cn/wiki/wikcnHqT9XlW24wHVLRwwyHMLCh#1JcZA7

@JaySon-Huang
Copy link
Contributor

Related TiDB issue: pingcap/tidb#34298

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants