dxf: cherrypick meter related PRs to nextgen

[D3Hunter]

What problem does this PR solve?

Issue Number: ref #61702

Problem Summary:

What changed and how does it work?

cherrypick below meter related PR

• dxf: fix metering might be lost when failed to write, and refactor #64358
• dxf: make api request metering more accurate by intercepting request call #64402
• disttask: fix flaky summary collection for ingest step #64471
• dxf: separate metered traffic into object storage and cluster and fix missing cluster traffic for import-into #64523
• add-index/import-into: meter row and kv size data and disable some options for import-into in nextgen #64584
• retry: avoid log un-retryable error when it's nil or context cancelled #64590

Check List

Tests

• Unit test
• Integration test
• Manual test (add detailed scripts or steps below)

we also did a test for this PR

import into

[2025/11/21 06:05:00.036 +00:00] [INFO] [metering.go:271] ["succeed to write metering data"] [keyspaceName=SYSTEM] [component=meter] [timestamp=1763705100] [duration=36.124812ms] [data="[{\"cluster_id\":\"SYSTEM\",\"cluster_write_bytes\":1025926823,\"get_requests\":2,\"obj_store_read_bytes\":8137,\"obj_store_write_bytes\":16327918296,\"put_requests\":3344,\"source_name\":\"dxf\",\"task_id\":120001,\"task_type\":\"ImportInto\",\"version\":\"1\"}]"]
[2025/11/21 06:06:00.071 +00:00] [INFO] [metering.go:271] ["succeed to write metering data"] [keyspaceName=SYSTEM] [component=meter] [timestamp=1763705160] [duration=71.131103ms] [data="[{\"cluster_id\":\"SYSTEM\",\"cluster_write_bytes\":1307440350,\"source_name\":\"dxf\",\"task_id\":120001,\"task_type\":\"ImportInto\",\"version\":\"1\"}]"]
[2025/11/21 06:07:00.050 +00:00] [INFO] [metering.go:271] ["succeed to write metering data"] [keyspaceName=SYSTEM] [component=meter] [timestamp=1763705220] [duration=49.292079ms] [data="[{\"cluster_id\":\"SYSTEM\",\"cluster_write_bytes\":1521888374,\"source_name\":\"dxf\",\"task_id\":120001,\"task_type\":\"ImportInto\",\"version\":\"1\"}]"]
[2025/11/21 06:08:00.041 +00:00] [INFO] [metering.go:271] ["succeed to write metering data"] [keyspaceName=SYSTEM] [component=meter] [timestamp=1763705280] [duration=40.658077ms] [data="[{\"cluster_id\":\"SYSTEM\",\"cluster_write_bytes\":1513961377,\"source_name\":\"dxf\",\"task_id\":120001,\"task_type\":\"ImportInto\",\"version\":\"1\"}]"]
[2025/11/21 06:09:00.021 +00:00] [INFO] [metering.go:271] ["succeed to write metering data"] [keyspaceName=SYSTEM] [component=meter] [timestamp=1763705340] [duration=21.851643ms] [data="[{\"cluster_id\":\"SYSTEM\",\"cluster_write_bytes\":1463248795,\"source_name\":\"dxf\",\"task_id\":120001,\"task_type\":\"ImportInto\",\"version\":\"1\"}]"]
[2025/11/21 06:10:00.053 +00:00] [INFO] [metering.go:271] ["succeed to write metering data"] [keyspaceName=SYSTEM] [component=meter] [timestamp=1763705400] [duration=52.979159ms] [data="[{\"cluster_id\":\"SYSTEM\",\"cluster_write_bytes\":1399361915,\"source_name\":\"dxf\",\"task_id\":120001,\"task_type\":\"ImportInto\",\"version\":\"1\"}]"]
[2025/11/21 06:11:00.039 +00:00] [INFO] [metering.go:271] ["succeed to write metering data"] [keyspaceName=SYSTEM] [component=meter] [timestamp=1763705460] [duration=39.689724ms] [data="[{\"cluster_id\":\"SYSTEM\",\"cluster_write_bytes\":1435951324,\"source_name\":\"dxf\",\"task_id\":120001,\"task_type\":\"ImportInto\",\"version\":\"1\"}]"]
[2025/11/21 06:12:00.034 +00:00] [INFO] [metering.go:271] ["succeed to write metering data"] [keyspaceName=SYSTEM] [component=meter] [timestamp=1763705520] [duration=33.758755ms] [data="[{\"cluster_id\":\"SYSTEM\",\"cluster_write_bytes\":1397594651,\"get_requests\":3999,\"obj_store_read_bytes\":11859943513,\"source_name\":\"dxf\",\"task_id\":120001,\"task_type\":\"ImportInto\",\"version\":\"1\"}]"]
[2025/11/21 06:13:00.027 +00:00] [INFO] [metering.go:271] ["succeed to write metering data"] [keyspaceName=SYSTEM] [component=meter] [timestamp=1763705580] [duration=26.692772ms] [data="[{\"cluster_id\":\"SYSTEM\",\"cluster_write_bytes\":2204930299,\"get_requests\":474,\"obj_store_read_bytes\":2465984834,\"source_name\":\"dxf\",\"task_id\":120001,\"task_type\":\"ImportInto\",\"version\":\"1\"}]"]
[2025/11/21 06:14:00.045 +00:00] [INFO] [metering.go:271] ["succeed to write metering data"] [keyspaceName=SYSTEM] [component=meter] [timestamp=1763705640] [duration=45.139024ms] [data="[{\"cluster_id\":\"SYSTEM\",\"cluster_write_bytes\":2047788971,\"get_requests\":711,\"obj_store_read_bytes\":3698977251,\"source_name\":\"dxf\",\"task_id\":120001,\"task_type\":\"ImportInto\",\"version\":\"1\"}]"]
[2025/11/21 06:14:20.758 +00:00] [INFO] [handle.go:421] ["succeed to send size and row metering data"] [keyspaceName=SYSTEM] [task-id=120001] [data="{\"cluster_id\":\"SYSTEM\",\"data_kv_bytes\":11065373609,\"index_kv_bytes\":4252719270,\"row_count\":10500000,\"source_name\":\"dxf\",\"task_id\":120001,\"task_type\":\"ImportInto\",\"version\":\"1\"}"] [duration=18.996906ms]
[2025/11/21 06:15:00.000 +00:00] [INFO] [metering.go:202] ["recorder unregistered and finished final flush"] [keyspaceName=SYSTEM] [component=meter] [accumulatedData="{id: 120001, keyspace: SYSTEM, type: ImportInto, requests{get: 5186, put: 3344}, obj_store{r: 16.79GiB, w: 15.21GiB}, cluster{r: 0B, w: 14.27GiB}"]

add index

[2025/11/21 07:15:00.095 +00:00] [INFO] [metering.go:271] ["succeed to write metering data"] [keyspaceName=SYSTEM] [component=meter] [timestamp=1763709300] [duration=95.051618ms] [data="[{\"cluster_id\":\"SYSTEM\",\"cluster_read_bytes\":321446567,\"source_name\":\"dxf\",\"task_id\":120002,\"task_type\":\"backfill\",\"version\":\"1\"}]"]
[2025/11/21 07:15:51.129 +00:00] [INFO] [handle.go:421] ["succeed to send size and row metering data"] [keyspaceName=SYSTEM] [task-id=120002] [data="{\"cluster_id\":\"SYSTEM\",\"index_kv_bytes\":808543854,\"row_count\":10500000,\"source_name\":\"dxf\",\"task_id\":120002,\"task_type\":\"backfill\",\"version\":\"1\"}"] [duration=19.356722ms]
[2025/11/21 07:16:00.039 +00:00] [INFO] [metering.go:271] ["succeed to write metering data"] [keyspaceName=SYSTEM] [component=meter] [timestamp=1763709360] [duration=39.452829ms] [data="[{\"cluster_id\":\"SYSTEM\",\"cluster_read_bytes\":9655196,\"cluster_write_bytes\":850543854,\"get_requests\":146,\"obj_store_read_bytes\":1046307043,\"obj_store_write_bytes\":1018733413,\"put_requests\":202,\"source_name\":\"dxf\",\"task_id\":120002,\"task_type\":\"backfill\",\"version\":\"1\"}]"]
[2025/11/21 07:16:00.039 +00:00] [INFO] [metering.go:202] ["recorder unregistered and finished final flush"] [keyspaceName=SYSTEM] [component=meter] [accumulatedData="{id: 120002, keyspace: SYSTEM, type: backfill, requests{get: 146, put: 202}, obj_store{r: 997.8MiB, w: 971.5MiB}, cluster{r: 315.8MiB, w: 811.1MiB}"]

• No need to test

  • I checked and no code files have been changed.

Side effects

• Performance regression: Consumes more CPU
• Performance regression: Consumes more Memory
• Breaking backward compatibility

Documentation

• Affects user behaviors
• Contains syntax changes
• Contains variable changes
• Contains experimental features
• Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

[tiprow]

Hi @D3Hunter. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[D3Hunter]

/retest

[tiprow]

@D3Hunter: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

Details

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[codecov]

Codecov Report

❌ Patch coverage is 52.96804% with 309 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (release-nextgen-20251011@f2fdda8). Learn more about missing BASE report.

Additional details and impacted files

@@                      Coverage Diff                      @@
##             release-nextgen-20251011     #64611   +/-   ##
=============================================================
  Coverage                            ?   71.8477%           
=============================================================
  Files                               ?       1828           
  Lines                               ?     490852           
  Branches                            ?          0           
=============================================================
  Hits                                ?     352666           
  Misses                              ?     115009           
  Partials                            ?      23177           

Flag	Coverage Δ
unit	71.8477% <52.9680%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
dumpling	52.8700% <0.0000%> (?)
parser	∅ <0.0000%> (?)
br	46.4975% <0.0000%> (?)

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[Benjamin2037]

LGTM

[ti-chi-bot]

[LGTM Timeline notifier]

Timeline:

• 2025-11-21 07:45:24.804237489 +0000 UTC m=+256888.453431936: ☑️ agreed by wjhuang2016.
• 2025-11-21 07:58:45.71660475 +0000 UTC m=+257689.365799207: ☑️ agreed by Benjamin2037.

[cfzjywxk]

LGTM for the go mod part

[ti-chi-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Benjamin2037, cfzjywxk, wjhuang2016

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [Benjamin2037,cfzjywxk,wjhuang2016]
• br/pkg/storage/OWNERS [Benjamin2037]
• pkg/ddl/OWNERS [Benjamin2037,wjhuang2016]
• pkg/disttask/OWNERS [Benjamin2037,wjhuang2016]
• pkg/domain/OWNERS [wjhuang2016]
• pkg/executor/importer/OWNERS [Benjamin2037]
• pkg/lightning/OWNERS [Benjamin2037]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment