dxf: separate metered traffic into object storage and cluster and fix missing cluster traffic for import-into#64523
Conversation
ti-chi-bot
Bot
added
release-note-none
|
Hi @D3Hunter. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #64523 +/- ##
================================================
+ Coverage 72.6909% 75.1041% +2.4131%
================================================
Files 1866 1889 +23
Lines 506250 516435 +10185
================================================
+ Hits 367998 387864 +19866
+ Misses 115882 104871 -11011
- Partials 22370 23700 +1330
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
| } | ||
|
|
||
| httpClient := opts.HTTPClient | ||
| if reqRec := recording.GetRequests(ctx); reqRec != nil { |
There was a problem hiding this comment.
to meter traffic, we need to have it inside object reader/writer, the old context var not fit in this scenario, so it's better pass it as a option
| writer = bw.writer | ||
| } | ||
| compressedWriter := newBufferedWriter(writer, hardcodedS3ChunkSize, w.compressType) | ||
| compressedWriter := newBufferedWriter(writer, hardcodedS3ChunkSize, w.compressType, nil) |
There was a problem hiding this comment.
Will we lose the records of bytes/requests for compression options?
There was a problem hiding this comment.
i add a comment, this withCompression is a wrapper around ExternalStorage which will do the recording
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: GMHDBJD, joechenrh The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ti-chi-bot
Bot
added
approved
and removed
needs-1-more-lgtm
|
/retest |
|
@D3Hunter: Cannot trigger testing until a trusted user reviews the PR and leaves an DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/retest |
|
@joechenrh: Cannot trigger testing until a trusted user reviews the PR and leaves an DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/retest |
|
@D3Hunter: Cannot trigger testing until a trusted user reviews the PR and leaves an DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/retest |
|
@D3Hunter: Cannot trigger testing until a trusted user reviews the PR and leaves an DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
… missing cluster traffic for import-into (pingcap#64523) close pingcap#61702
3 participants
What problem does this PR solve?
Issue Number: ref #61702
Problem Summary:
What changed and how does it work?
Check List
Tests
when set
tidb_cloud_storage_urito S3when set
tidb_cloud_storage_urito KS3, the time difference is due to different resource amplify factor.Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.