Skip to content

dxf/ddl: always enable DXF and fast reorg in nextgen (#64179)#64208

Merged
ti-chi-bot[bot] merged 2 commits into
pingcap:release-nextgen-20251011from
ti-chi-bot:cherry-pick-64179-to-release-nextgen-20251011
Oct 31, 2025
Merged

dxf/ddl: always enable DXF and fast reorg in nextgen (#64179)#64208
ti-chi-bot[bot] merged 2 commits into
pingcap:release-nextgen-20251011from
ti-chi-bot:cherry-pick-64179-to-release-nextgen-20251011

Conversation

@ti-chi-bot

Copy link
Copy Markdown
Member

This is an automated cherry-pick of #64179

What problem does this PR solve?

Issue Number: ref #61702

Problem Summary:

What changed and how does it work?

since the default value of those 2 variable is true now, we achieve this by disallowing setting those variables

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. type/cherry-pick-for-release-nextgen-20251011 labels Oct 31, 2025
@ti-chi-bot

Copy link
Copy Markdown
Member Author

@D3Hunter This PR has conflicts, I have hold it.
Please resolve them or ask others to resolve them, then comment /unhold to remove the hold label.

@ti-chi-bot

ti-chi-bot Bot commented Oct 31, 2025

Copy link
Copy Markdown

@ti-chi-bot: ## If you want to know how to resolve it, please read the guide in TiDB Dev Guide.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot Bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Oct 31, 2025
@D3Hunter

Copy link
Copy Markdown
Contributor

/unhold

@ti-chi-bot ti-chi-bot Bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 31, 2025

@Benjamin2037 Benjamin2037 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot

ti-chi-bot Bot commented Oct 31, 2025

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Benjamin2037, D3Hunter

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot Bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Oct 31, 2025
@ti-chi-bot

ti-chi-bot Bot commented Oct 31, 2025

Copy link
Copy Markdown

[LGTM Timeline notifier]

Timeline:

  • 2025-10-31 05:36:58.867061023 +0000 UTC m=+1627724.944313573: ☑️ agreed by D3Hunter.
  • 2025-10-31 05:47:17.878891724 +0000 UTC m=+1628343.956144284: ☑️ agreed by Benjamin2037.

@codecov

codecov Bot commented Oct 31, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (release-nextgen-20251011@c634954). Learn more about missing BASE report.

Additional details and impacted files
@@                      Coverage Diff                      @@
##             release-nextgen-20251011     #64208   +/-   ##
=============================================================
  Coverage                            ?   72.3071%           
=============================================================
  Files                               ?       1855           
  Lines                               ?     501419           
  Branches                            ?          0           
=============================================================
  Hits                                ?     362562           
  Misses                              ?     116700           
  Partials                            ?      22157           
Flag Coverage Δ
unit 71.8123% <100.0000%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.8700% <0.0000%> (?)
parser ∅ <0.0000%> (?)
br 46.4311% <0.0000%> (?)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ti-chi-bot ti-chi-bot Bot merged commit 6362855 into pingcap:release-nextgen-20251011 Oct 31, 2025
17 checks passed
@ti-chi-bot ti-chi-bot Bot deleted the cherry-pick-64179-to-release-nextgen-20251011 branch October 31, 2025 06:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. type/cherry-pick-for-release-nextgen-20251011

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants