dxf/ddl: always enable DXF and fast reorg in nextgen#64179
Conversation
ti-chi-bot
Bot
added
release-note-none
|
Hi @D3Hunter. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
|
||
| func TestAddIndexUniqueFailOnDuplicate(t *testing.T) { | ||
| if kerneltype.IsNextGen() { | ||
| t.Skip("add-index always runs on DXF with ingest mode in nextgen") |
There was a problem hiding this comment.
those tests will disable DXF
|
|
||
| tk := testkit.NewTestKit(t, store) | ||
| tk.MustExec("use test") | ||
| tk.MustExec("set global tidb_ddl_enable_fast_reorg = 1;") |
There was a problem hiding this comment.
the default is 1, so no need to set it again
| tk.MustExec("use fk_index;") | ||
| tk.MustExec(`set global tidb_ddl_enable_fast_reorg=1;`) | ||
| if kerneltype.IsClassic() { | ||
| tk.MustExec(`set global tidb_ddl_enable_fast_reorg=1;`) |
There was a problem hiding this comment.
in realtikv test, cluster is shared, some case might disable it, so we keep it
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #64179 +/- ##
================================================
+ Coverage 72.6867% 75.4352% +2.7484%
================================================
Files 1858 1882 +24
Lines 502672 518759 +16087
================================================
+ Hits 365376 391327 +25951
+ Misses 115060 103962 -11098
- Partials 22236 23470 +1234
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
ti-chi-bot
Bot
added
lgtm
and removed
needs-1-more-lgtm
[LGTM Timeline notifier]Timeline:
|
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: D3Hunter, tangenta, wjhuang2016 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
|
@D3Hunter: Cannot trigger testing until a trusted user reviews the PR and leaves an DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/cherry-pick release-nextgen-20251011 |
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
|
@D3Hunter: new pull request created to branch DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
4 participants
What problem does this PR solve?
Issue Number: ref #61702
Problem Summary:
What changed and how does it work?
since the default value of those 2 variable is true now, we achieve this by disallowing setting those variables
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.