mdl: move the set variable check of nextgen from variable pkg to planner#62882
Conversation
|
Hi @D3Hunter. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Codecov Report❌ Patch coverage is Please upload reports for the commit 3193383 to get more accurate results. Additional details and impacted files@@ Coverage Diff @@
## master #62882 +/- ##
================================================
+ Coverage 72.8011% 73.4145% +0.6134%
================================================
Files 1792 1822 +30
Lines 487624 495787 +8163
================================================
+ Hits 354996 363980 +8984
+ Misses 111008 109467 -1541
- Partials 21620 22340 +720
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
|
/retest |
|
@D3Hunter: Cannot trigger testing until a trusted user reviews the PR and leaves an DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/retest |
|
@D3Hunter: Cannot trigger testing until a trusted user reviews the PR and leaves an DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/retest |
|
@D3Hunter: Cannot trigger testing until a trusted user reviews the PR and leaves an DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/retest |
|
@D3Hunter: Cannot trigger testing until a trusted user reviews the PR and leaves an DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/hold some case keeps failing, investigating, but it runs fine locally, i also see it in other PR, might be some other cases forget to revert the changes to global variables. see #62889 |
|
/unhold |
|
/retest |
|
@D3Hunter: Cannot trigger testing until a trusted user reviews the PR and leaves an DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/retest |
|
@D3Hunter: Cannot trigger testing until a trusted user reviews the PR and leaves an DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: GMHDBJD, hawkingrei, qw4990, tangenta, yudongusa The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/ok-to-test |
What problem does this PR solve?
Issue Number: ref #61702
Problem Summary:
What changed and how does it work?
in #62865, we forbid setting enableMDL var, but I didn't notice that
Domain.rebuildSysVarCachewill callSetGlobaldirectly, which will cause logging of the errorsetting tidb_enable_metadata_lock is not supported in the next generation of TiDB, although there is no harm, it's not expected, so we move the check to planner ofset statementCheck List
Tests
TestSetMDLInNextGenalso workrun nextgen TiDB, there is no log like
setting tidb_enable_metadata_lock is not supported in the next generation of TiDBSide effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.