Skip to content

mdl: always enable and make it read only in nextgen#62865

Merged
ti-chi-bot[bot] merged 1 commit into
pingcap:masterfrom
D3Hunter:always-enable-mdl
Aug 7, 2025
Merged

mdl: always enable and make it read only in nextgen#62865
ti-chi-bot[bot] merged 1 commit into
pingcap:masterfrom
D3Hunter:always-enable-mdl

Conversation

@D3Hunter

@D3Hunter D3Hunter commented Aug 6, 2025

Copy link
Copy Markdown
Contributor

What problem does this PR solve?

Issue Number: ref #61702

Problem Summary:

What changed and how does it work?

as title

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot Bot added release-note-none Denotes a PR that doesn't merit a release note. sig/planner SIG: Planner size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 6, 2025
@tiprow

tiprow Bot commented Aug 6, 2025

Copy link
Copy Markdown

Hi @D3Hunter. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@codecov

codecov Bot commented Aug 6, 2025

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 60.52632% with 15 lines in your changes missing coverage. Please review.
✅ Project coverage is 74.7295%. Comparing base (5f051c7) to head (f813db3).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #62865        +/-   ##
================================================
+ Coverage   72.7927%   74.7295%   +1.9368%     
================================================
  Files          1792       1838        +46     
  Lines        487597     495809      +8212     
================================================
+ Hits         354935     370516     +15581     
+ Misses       111041     102173      -8868     
- Partials      21621      23120      +1499     
Flag Coverage Δ
integration 48.7465% <28.9473%> (?)
unit 72.1601% <60.5263%> (-0.0170%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.8700% <ø> (ø)
parser ∅ <ø> (∅)
br 63.0652% <ø> (+16.7410%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Benjamin2037 Benjamin2037 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot Bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Aug 7, 2025
@ti-chi-bot ti-chi-bot Bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Aug 7, 2025
@ti-chi-bot

ti-chi-bot Bot commented Aug 7, 2025

Copy link
Copy Markdown

[LGTM Timeline notifier]

Timeline:

  • 2025-08-07 02:27:28.661259164 +0000 UTC m=+494358.804020339: ☑️ agreed by Benjamin2037.
  • 2025-08-07 03:27:50.487497861 +0000 UTC m=+497980.630259026: ☑️ agreed by lance6716.

@ti-chi-bot

ti-chi-bot Bot commented Aug 7, 2025

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Benjamin2037, hawkingrei, lance6716, yudongusa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot Bot added the approved label Aug 7, 2025
@ti-chi-bot ti-chi-bot Bot merged commit 2d07f5c into pingcap:master Aug 7, 2025
28 checks passed
@D3Hunter D3Hunter deleted the always-enable-mdl branch August 7, 2025 06:15
D3Hunter added a commit to D3Hunter/tidb that referenced this pull request Aug 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved lgtm release-note-none Denotes a PR that doesn't merit a release note. sig/planner SIG: Planner size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants