*: upgrade pd client to fix keyspace issue by lhy1024 · Pull Request #62189 · pingcap/tidb

lhy1024 · 2025-07-03T09:55:23Z

What problem does this PR solve?

Issue Number: close #62188

Problem Summary:

What changed and how does it work?

Check List

Tests

Unit test
Manual test (add detailed scripts or steps below)

File: tidb.toml
keyspace-name = "SYSTEM"

File: tikv.toml
[storage]
enable-ttl = true
api-version = 2

cd ~/tidb
NEXT_GEN=1 make server
cd ~/pd
NEXT_GEN=1 make pd-server
tiup playground nightly --kv 3 --tiflash 0 --host 0.0.0.0 --db.binpath=~/tidb/bin/tidb-server --pd.binpath=~/pd/bin/pd-server --db.config=~/tidb.toml --kv.config=~/tikv.toml

cd tests/integrationtest;                                                                                                                       ~/tidb
./mysql_tester -port 4000 --check-error=true --collation-disable=false --record ddl/resource_group
./t/ddl/resource_group.test: ok! 16 test cases passed, take time 1.441095362 s

Great, All tests passed

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

tiprow · 2025-07-03T09:56:02Z

Hi @lhy1024. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

lhy1024 · 2025-07-03T09:57:44Z

/check-issue-triage-complete

lhy1024 · 2025-07-03T10:07:16Z

/retest-required

tiprow · 2025-07-03T10:07:39Z

@lhy1024: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

Details

In response to this:

/retest-required

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

codecov · 2025-07-03T10:41:12Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.0306%. Comparing base (91dcec4) to head (90b3e61).
Report is 12 commits behind head on master.

Additional details and impacted files

@@               Coverage Diff                @@
##             master     #62189        +/-   ##
================================================
+ Coverage   72.9181%   74.0306%   +1.1125%     
================================================
  Files          1740       1748         +8     
  Lines        483072     489993      +6921     
================================================
+ Hits         352247     362745     +10498     
+ Misses       109244     105888      -3356     
+ Partials      21581      21360       -221

Flag	Coverage Δ
integration	`42.8438% <ø> (?)`
unit	`72.9575% <ø> (+0.7981%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
dumpling	`52.7804% <ø> (ø)`
parser	`∅ <ø> (∅)`
br	`46.3451% <ø> (+0.0102%)`	⬆️

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

lhy1024 · 2025-07-03T10:51:44Z

/retest-required

tiprow · 2025-07-03T10:52:08Z

@lhy1024: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

Details

In response to this:

/retest-required

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Signed-off-by: lhy1024 <admin@liudos.us>

ti-chi-bot · 2025-07-04T03:17:45Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cfzjywxk, tiancaiamao

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [cfzjywxk,tiancaiamao]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

ti-chi-bot · 2025-07-04T03:17:48Z

[LGTM Timeline notifier]

Timeline:

2025-07-03 10:28:43.322261822 +0000 UTC m=+1563576.045440804: ☑️ agreed by tiancaiamao.
2025-07-04 03:17:47.660998761 +0000 UTC m=+1624120.384177742: ☑️ agreed by cfzjywxk.

lhy1024 · 2025-07-04T05:21:10Z

/retest-required

tiprow · 2025-07-04T05:21:43Z

@lhy1024: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

Details

In response to this:

/retest-required

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

cfzjywxk · 2025-07-04T06:10:07Z

/ok-to-test

cfzjywxk · 2025-07-04T06:10:13Z

/retest

tiprow · 2025-07-04T06:10:38Z

@cfzjywxk: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

Details

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

lhy1024 · 2025-07-04T06:31:45Z

/test unit-test

tiprow · 2025-07-04T06:32:06Z

@lhy1024: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

Details

In response to this:

/test unit-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

lhy1024 · 2025-07-04T07:32:23Z

/test unit-test

tiprow · 2025-07-04T07:32:45Z

@lhy1024: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

Details

In response to this:

/test unit-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

* origin/master: (79 commits) backend/local: add rate limiter for split region and ingest data (pingcap#61555) fix(runaway): resolve the dead channel in UpdateNewAndDoneWatch (pingcap#61795) *: collect subtask summary for `IMPORT INTO` tasks (pingcap#61600) tests: update vector cluster test result (pingcap#62174) planner: change casetest instance-plan-cache test timeout. (pingcap#62195) planner: remove data race for instance plan cache (pingcap#62217) *: upgrade pd client to fix keyspace issue (pingcap#62189) resource_control: support collecting cross AZ traffic in ru consumption (pingcap#62003) test: wait for statistics owner to close on exit (pingcap#62198) planner: remove the selection above the table dual (pingcap#62193) telemetry: add telemetry related code back (pingcap#61753) planner: move physical limit related logic into physical op. (pingcap#62187) planner: remove useless code (pingcap#61968) retry: enhance retry for ingestor on nextgen (pingcap#62191) importinto: encode and ingest step use task keyspace in nextgen (pingcap#62138) planner: lift the can-push-to-cop check of aggregation/proj (pingcap#62068) ddl: cannot panic with failpoint panic in the DDLNotifier (pingcap#62151) planner: skip empty expression in the applyPredicateSimplification (pingcap#62178) codec: should also return the value even with error because the error may be ignored in the future (pingcap#62175) parser: also reduce literal list with charset (pingcap#61484) ...

ti-chi-bot Bot added do-not-merge/needs-triage-completed do-not-merge/needs-tests-checked release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 3, 2025

ti-chi-bot Bot removed do-not-merge/needs-triage-completed do-not-merge/needs-tests-checked labels Jul 3, 2025

tiancaiamao approved these changes Jul 3, 2025

View reviewed changes

ti-chi-bot Bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Jul 3, 2025

ti-chi-bot Bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 3, 2025

*: upgrade pd client to fix keyspace issue

90b3e61

Signed-off-by: lhy1024 <admin@liudos.us>

lhy1024 force-pushed the update-pd2 branch from 0c9f47d to 90b3e61 Compare July 3, 2025 11:45

cfzjywxk approved these changes Jul 4, 2025

View reviewed changes

ti-chi-bot Bot added approved lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jul 4, 2025

ti-chi-bot Bot merged commit 6982396 into pingcap:master Jul 4, 2025
24 checks passed

Uh oh!

Conversation

lhy1024 commented Jul 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What problem does this PR solve?

What changed and how does it work?

Check List

Release note

Uh oh!

tiprow Bot commented Jul 3, 2025

Uh oh!

lhy1024 commented Jul 3, 2025

Uh oh!

lhy1024 commented Jul 3, 2025

Uh oh!

tiprow Bot commented Jul 3, 2025

Uh oh!

codecov Bot commented Jul 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

lhy1024 commented Jul 3, 2025

Uh oh!

tiprow Bot commented Jul 3, 2025

Uh oh!

ti-chi-bot Bot commented Jul 4, 2025

Uh oh!

ti-chi-bot Bot commented Jul 4, 2025

[LGTM Timeline notifier]

Uh oh!

lhy1024 commented Jul 4, 2025

Uh oh!

tiprow Bot commented Jul 4, 2025

Uh oh!

cfzjywxk commented Jul 4, 2025

Uh oh!

cfzjywxk commented Jul 4, 2025

Uh oh!

tiprow Bot commented Jul 4, 2025

Uh oh!

lhy1024 commented Jul 4, 2025

Uh oh!

tiprow Bot commented Jul 4, 2025

Uh oh!

lhy1024 commented Jul 4, 2025

Uh oh!

tiprow Bot commented Jul 4, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

lhy1024 commented Jul 3, 2025 •

edited

Loading

codecov Bot commented Jul 3, 2025 •

edited

Loading