Skip to content

planner: move physical limit related logic into physical op.#62187

Merged
ti-chi-bot[bot] merged 12 commits into
pingcap:masterfrom
AilinKid:move-physical-limit
Jul 4, 2025
Merged

planner: move physical limit related logic into physical op.#62187
ti-chi-bot[bot] merged 12 commits into
pingcap:masterfrom
AilinKid:move-physical-limit

Conversation

@AilinKid

@AilinKid AilinKid commented Jul 3, 2025

Copy link
Copy Markdown
Contributor

What problem does this PR solve?

Issue Number: ref #52714

Problem Summary:

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@AilinKid
.
9a028c5 
Signed-off-by: AilinKid <314806019@qq.com>
@ti-chi-bot ti-chi-bot Bot added release-note-none Denotes a PR that doesn't merit a release note. sig/planner SIG: Planner size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jul 3, 2025
@tiprow

tiprow Bot commented Jul 3, 2025

Copy link
Copy Markdown

Hi @AilinKid. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@AilinKid
.
5774f96 
Signed-off-by: AilinKid <314806019@qq.com>
@ti-chi-bot ti-chi-bot Bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jul 3, 2025
@ti-chi-bot

ti-chi-bot Bot commented Jul 3, 2025

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hawkingrei, zimulala

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot Bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jul 3, 2025
@ti-chi-bot

ti-chi-bot Bot commented Jul 3, 2025

Copy link
Copy Markdown

[LGTM Timeline notifier]

Timeline:

  • 2025-07-03 09:56:19.286843472 +0000 UTC m=+1561632.010022526: ☑️ agreed by hawkingrei.
  • 2025-07-03 10:00:34.952278878 +0000 UTC m=+1561887.675457859: ☑️ agreed by zimulala.

AilinKid added 2 commits July 3, 2025 18:03
@AilinKid
.
4949637 
Signed-off-by: AilinKid <314806019@qq.com>
@AilinKid
.
bfa64dc 
Signed-off-by: AilinKid <314806019@qq.com>
@codecov

codecov Bot commented Jul 3, 2025 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 74.76636% with 27 lines in your changes missing coverage. Please review.

Project coverage is 73.3851%. Comparing base (a900a31) to head (f3adf11).
Report is 14 commits behind head on master.

Additional details and impacted files 
@@               Coverage Diff                @@
##             master     #62187        +/-   ##
================================================
+ Coverage   72.9076%   73.3851%   +0.4774%     
================================================
  Files          1740       1742         +2     
  Lines        482993     484973      +1980     
================================================
+ Hits         352139     355898      +3759     
+ Misses       109256     107493      -1763     
+ Partials      21598      21582        -16
Flag Coverage Δ
integration 42.3102% <57.2815%> (?)
unit 72.1957% <74.7663%> (+0.0421%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.7804% <ø> (ø)
parser ∅ <ø> (∅)
br 46.3451% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

AilinKid added 2 commits July 3, 2025 21:38
@AilinKid
.
8675941 
Signed-off-by: AilinKid <314806019@qq.com>
@AilinKid
.
9f9b560 
Signed-off-by: AilinKid <314806019@qq.com>
@hawkingrei

hawkingrei commented Jul 3, 2025

Copy link
Copy Markdown
Contributor

/retest

@tiprow

tiprow Bot commented Jul 3, 2025

Copy link
Copy Markdown

@AilinKid: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
fast_test_tiprow 9f9b560 link true /test fast_test_tiprow

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

AilinKid added 6 commits July 3, 2025 22:59
@AilinKid
.
e872198 
Signed-off-by: AilinKid <314806019@qq.com>
@AilinKid
.
0b0e24b 
Signed-off-by: AilinKid <314806019@qq.com>
@AilinKid
.
36a5a67 
Signed-off-by: AilinKid <314806019@qq.com>
@AilinKid
.
91a30ee 
Signed-off-by: AilinKid <314806019@qq.com>
@AilinKid
.
b9649c5 
Signed-off-by: AilinKid <314806019@qq.com>
@AilinKid
.
f3adf11 
Signed-off-by: AilinKid <314806019@qq.com>
@ti-chi-bot ti-chi-bot Bot merged commit 9f1396b into pingcap:master Jul 4, 2025
22 checks passed
morgo added a commit to morgo/tidb that referenced this pull request Jul 7, 2025
@morgo
Merge remote-tracking branch 'origin/master' into identifier-in-default
414a7a8 
* origin/master: (79 commits)
  backend/local: add rate limiter for split region and ingest data (pingcap#61555)
  fix(runaway): resolve the dead channel in UpdateNewAndDoneWatch (pingcap#61795)
  *: collect subtask summary for `IMPORT INTO` tasks (pingcap#61600)
  tests: update vector cluster test result (pingcap#62174)
  planner: change casetest instance-plan-cache test timeout. (pingcap#62195)
  planner: remove data race for instance plan cache (pingcap#62217)
  *: upgrade pd client to fix keyspace issue (pingcap#62189)
  resource_control: support collecting cross AZ traffic in ru consumption (pingcap#62003)
  test: wait for statistics owner to close on exit (pingcap#62198)
  planner: remove the selection above the table dual (pingcap#62193)
  telemetry: add telemetry related code back (pingcap#61753)
  planner: move physical limit related logic into physical op. (pingcap#62187)
  planner: remove useless code (pingcap#61968)
  retry: enhance retry for ingestor on nextgen (pingcap#62191)
  importinto: encode and ingest step use task keyspace in nextgen (pingcap#62138)
  planner: lift the can-push-to-cop check of aggregation/proj (pingcap#62068)
  ddl: cannot panic with failpoint panic in the DDLNotifier (pingcap#62151)
  planner: skip empty expression in the applyPredicateSimplification (pingcap#62178)
  codec: should also return the value even with error because the error may be ignored in the future (pingcap#62175)
  parser: also reduce literal list with charset (pingcap#61484)
  ...
morgo added a commit to morgo/tidb that referenced this pull request Jul 7, 2025
@morgo
Merge remote-tracking branch 'origin/master' into identifier-in-default
23bc18d 
* origin/master: (79 commits)
  backend/local: add rate limiter for split region and ingest data (pingcap#61555)
  fix(runaway): resolve the dead channel in UpdateNewAndDoneWatch (pingcap#61795)
  *: collect subtask summary for `IMPORT INTO` tasks (pingcap#61600)
  tests: update vector cluster test result (pingcap#62174)
  planner: change casetest instance-plan-cache test timeout. (pingcap#62195)
  planner: remove data race for instance plan cache (pingcap#62217)
  *: upgrade pd client to fix keyspace issue (pingcap#62189)
  resource_control: support collecting cross AZ traffic in ru consumption (pingcap#62003)
  test: wait for statistics owner to close on exit (pingcap#62198)
  planner: remove the selection above the table dual (pingcap#62193)
  telemetry: add telemetry related code back (pingcap#61753)
  planner: move physical limit related logic into physical op. (pingcap#62187)
  planner: remove useless code (pingcap#61968)
  retry: enhance retry for ingestor on nextgen (pingcap#62191)
  importinto: encode and ingest step use task keyspace in nextgen (pingcap#62138)
  planner: lift the can-push-to-cop check of aggregation/proj (pingcap#62068)
  ddl: cannot panic with failpoint panic in the DDLNotifier (pingcap#62151)
  planner: skip empty expression in the applyPredicateSimplification (pingcap#62178)
  codec: should also return the value even with error because the error may be ignored in the future (pingcap#62175)
  parser: also reduce literal list with charset (pingcap#61484)
  ...
morgo added a commit to morgo/tidb that referenced this pull request Jul 7, 2025
@morgo
Merge remote-tracking branch 'origin/master' into identifier-in-default
f645f5b 
* origin/master: (79 commits)
  backend/local: add rate limiter for split region and ingest data (pingcap#61555)
  fix(runaway): resolve the dead channel in UpdateNewAndDoneWatch (pingcap#61795)
  *: collect subtask summary for `IMPORT INTO` tasks (pingcap#61600)
  tests: update vector cluster test result (pingcap#62174)
  planner: change casetest instance-plan-cache test timeout. (pingcap#62195)
  planner: remove data race for instance plan cache (pingcap#62217)
  *: upgrade pd client to fix keyspace issue (pingcap#62189)
  resource_control: support collecting cross AZ traffic in ru consumption (pingcap#62003)
  test: wait for statistics owner to close on exit (pingcap#62198)
  planner: remove the selection above the table dual (pingcap#62193)
  telemetry: add telemetry related code back (pingcap#61753)
  planner: move physical limit related logic into physical op. (pingcap#62187)
  planner: remove useless code (pingcap#61968)
  retry: enhance retry for ingestor on nextgen (pingcap#62191)
  importinto: encode and ingest step use task keyspace in nextgen (pingcap#62138)
  planner: lift the can-push-to-cop check of aggregation/proj (pingcap#62068)
  ddl: cannot panic with failpoint panic in the DDLNotifier (pingcap#62151)
  planner: skip empty expression in the applyPredicateSimplification (pingcap#62178)
  codec: should also return the value even with error because the error may be ignored in the future (pingcap#62175)
  parser: also reduce literal list with charset (pingcap#61484)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zimulala zimulala zimulala approved these changes
+1 more reviewer
@hawkingrei hawkingrei hawkingrei approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved lgtm release-note-none Denotes a PR that doesn't merit a release note. sig/planner SIG: Planner size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@AilinKid @hawkingrei @zimulala