Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

statistics: optimize stats delta dumping with batch processing #58791

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
+205 −90
Open

statistics: optimize stats delta dumping with batch processing #58791

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
e2678d1
statistics: optimize stats delta dumping with batch processing
Rustin170506 Jan 8, 2025
748e191
statistics: add logutil and zap dependencies to usage library
Rustin170506 Jan 8, 2025
d801b1c
statistics: simplify DeltaUpdate creation in stats delta dumping
Rustin170506 Jan 8, 2025
35e7c3c
statistics: add batch stats delta dump test
Rustin170506 Jan 8, 2025
ab24c3b
statistics: update comment to clarify batch stats delta dumping
Rustin170506 Jan 8, 2025
403134e
statistics: fix assertion in DumpStatsDeltaToKV to use correct length…
Rustin170506 Jan 8, 2025
ef738d2
statistics: reduce too slow threshold and change log level to warn fo…
Rustin170506 Jan 9, 2025
a035e98
statistics: add logging for slow historical stats recording and dumpi…
Rustin170506 Jan 9, 2025
c89feb1
statistics: add conditional check for recording historical stats meta…
Rustin170506 Jan 9, 2025
a3cf47b
statistics: remove timing log for stats delta dumping to streamline p…
Rustin170506 Jan 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
statistics: update comment to clarify batch stats delta dumping 
Signed-off-by: Rustin170506 <techregister@pm.me>
  • Loading branch information
@Rustin170506
Rustin170506 committed Jan 8, 2025
commit ab24c3b0f8ed191ae52e627ce2300d01a5930f7c
2 changes: 1 addition & 1 deletion pkg/statistics/handle/handletest/statstest/stats_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -449,7 +449,7 @@ func TestDumpStatsDeltaInBatch(t *testing.T) {
testKit.MustExec("create table t2 (c1 int, c2 int)")
testKit.MustExec("insert into t2 values (1, 1), (2, 2), (3, 3)")

// Dump stats delta once.
// Dump stats delta in one batch.
handle := dom.StatsHandle()
require.NoError(t, handle.DumpStatsDeltaToKV(true))

Expand Down