statistics: optimize stats delta dumping with batch processing #58791
+205
−90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rustin170506 <techregister@pm.me>
ti-chi-bot
bot
added
release-note
Signed-off-by: Rustin170506 <techregister@pm.me>
Signed-off-by: Rustin170506 <techregister@pm.me>
Signed-off-by: Rustin170506 <techregister@pm.me>
ti-chi-bot
bot
added
size/XL
Signed-off-by: Rustin170506 <techregister@pm.me>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #58791 +/- ##
================================================
+ Coverage 73.0741% 73.8635% +0.7894%
================================================
Files 1676 1707 +31
Lines 463762 475271 +11509
================================================
+ Hits 338890 351052 +12162
+ Misses 104006 102581 -1425
- Partials 20866 21638 +772
Flags with carried forward coverage won't be shown. Click here to find out more.
|
… check for batchUpdates Signed-off-by: Rustin170506 <techregister@pm.me>
|
/retest |
1 similar comment
|
/retest |
winoros
approved these changes
Jan 8, 2025
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: winoros The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ti-chi-bot
bot
added
approved
needs-1-more-lgtm
[LGTM Timeline notifier]Timeline:
|
|
I tested this PR on the real cluster: 
Before this change:
After this change: |
…r slow operations Signed-off-by: Rustin170506 <techregister@pm.me>
…ng operations Signed-off-by: Rustin170506 <techregister@pm.me>
… and improve performance logging Signed-off-by: Rustin170506 <techregister@pm.me>
|
/retest |
…erformance Signed-off-by: Rustin170506 <techregister@pm.me>
Rustin170506
commented
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #57869
close #58331
Problem Summary:
What changed and how does it work?
In this PR I changed
DumpStatsDeltaToKVto dump the stats in batch instead of one by one. This will significantly improve the performance of the dump process. From my tests, the duration dropped from 40 minutes to 20 seconds under 100m table workload.See more: #57869 (comment)
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.