Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: improve performance of show variables #5363

Merged
merged 5 commits into from
Dec 11, 2017

Conversation

XuHuaiyu
Copy link
Contributor

@XuHuaiyu XuHuaiyu commented Dec 11, 2017

cherry-pick from master commits #4895 #5291 #5297 #5317
PTAL @shenli @coocood

if err != nil {
return "", errors.Trace(err)
}
s.Systems[key] = gVal
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we remove this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is useful, CI failed since the two commits use an interface which is defined by other commits.
I'll take a look.

Copy link
Contributor

@winkyao winkyao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix ci

@XuHuaiyu
Copy link
Contributor Author

PTAL @winkyao @shenli

@shenli
Copy link
Member

shenli commented Dec 11, 2017

LGTM

@shenli
Copy link
Member

shenli commented Dec 11, 2017

/run-all-tests -tidb-test=release-1.0

@XuHuaiyu
Copy link
Contributor Author

/run-unit-test

Copy link
Contributor

@winkyao winkyao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@coocood coocood merged commit 19e32aa into pingcap:release-1.0 Dec 11, 2017
@XuHuaiyu XuHuaiyu deleted the release-1.0 branch December 11, 2017 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants