Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

*: session variable value should not be modified when get global variable #5317

Merged
merged 4 commits into from
Dec 6, 2017
Merged

*: session variable value should not be modified when get global variable #5317

merged 4 commits into from
Dec 6, 2017

Conversation

XuHuaiyu
Copy link
Contributor

@XuHuaiyu XuHuaiyu commented Dec 6, 2017

PTAL @coocood

@XuHuaiyu
Copy link
Contributor Author

XuHuaiyu commented Dec 6, 2017

/run-all-tests

@XuHuaiyu
Copy link
Contributor Author

XuHuaiyu commented Dec 6, 2017

/run-common-test tidb-test=pr/421
/run-integration-tests tidb-test=pr/421

@XuHuaiyu
Copy link
Contributor Author

XuHuaiyu commented Dec 6, 2017

/run-integration-common-tests tidb-test=pr/421

@XuHuaiyu
Copy link
Contributor Author

XuHuaiyu commented Dec 6, 2017

/run-all-tests

@XuHuaiyu
Copy link
Contributor Author

XuHuaiyu commented Dec 6, 2017

PTAL @coocood @shenli

coocood
coocood reviewed Dec 6, 2017
View reviewed changes
Copy link
Member

@coocood coocood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shenli
Copy link
Member

shenli commented Dec 6, 2017

LGTM

@coocood coocood merged commit 738f933 into pingcap:master Dec 6, 2017
@XuHuaiyu XuHuaiyu mentioned this pull request Dec 11, 2017
Merged
XuHuaiyu added a commit to XuHuaiyu/tidb that referenced this pull request Dec 11, 2017
@XuHuaiyu
*: session variable value should not be modified when get global vari…
4dd6378 
…able (pingcap#5317)
coocood pushed a commit that referenced this pull request Dec 11, 2017
@XuHuaiyu @coocood
*: improve performance of show variables (#5363)
19e32aa 
* show: fix variable scope error (#5291)

* *: improve performance of show variables (#5297)

* *: session variable value should not be modified when get global variable (#5317)

* fix ci

* ddl,expression: make leak test more stable (#4895)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coocood coocood coocood approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@XuHuaiyu @shenli @coocood