-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
executor: check schema when build table reader executor (#50425) #50561
executor: check schema when build table reader executor (#50425) #50561
Conversation
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
This cherry pick PR is for a release branch and has not yet been approved by triage owners. To merge this cherry pick:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## release-6.5 #50561 +/- ##
================================================
Coverage ? 73.6515%
================================================
Files ? 1096
Lines ? 351436
Branches ? 0
================================================
Hits ? 258838
Misses ? 75966
Partials ? 16632 |
[LGTM Timeline notifier]Timeline:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: AilinKid, elsa0520, hawkingrei, qw4990 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This is an automated cherry-pick of #50425
What problem does this PR solve?
Issue Number: ref #50358
Problem Summary:
Described in #50358
What changed and how does it work?
Quick fix for the issue in executor. Had tried to fix it in planner phase, but failed with so many test failures: #50410
May try to fix it in planner phase later.
Check List
Tests
Try to run cross join queries with high concurrency, and check no empty result sets are found
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.