-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
planner: add eliminate projections rule after join reorder #50410
Conversation
Signed-off-by: yibin <huyibin@pingcap.com>
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @yibin87. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Signed-off-by: yibin <huyibin@pingcap.com>
/cc @elsa0520 @hawkingrei |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #50410 +/- ##
=================================================
- Coverage 70.0709% 53.6128% -16.4581%
=================================================
Files 1444 1553 +109
Lines 420010 586900 +166890
=================================================
+ Hits 294305 314654 +20349
- Misses 105423 248386 +142963
- Partials 20282 23860 +3578
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Signed-off-by: yibin <huyibin@pingcap.com>
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@yibin87: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
What problem does this PR solve?
Issue Number: ref #50358
Problem Summary:
Described in #50358
What changed and how does it work?
A quick fix to pass existing regression test. Since join reorder may add new projections, add projection eliminator rule after it. Had tried to change column prune rule to keep at least one column for logical projection, but failed:
select count(1) from (select (select count(t1.a) as a from t t1 where t1.c = t2.c) as a from t t2) as t3
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.