disttask/ddl: fix pause succeed task then run a new task (#47804) #47935
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ti-chi-bot
added
ok-to-test
13 tasks
ti-chi-bot
added
the
cherry-pick-approved
|
/retest |
2 similar comments
|
/retest |
|
/retest |
ywqzzy
approved these changes
Oct 25, 2023
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Benjamin2037, ywqzzy The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ti-chi-bot
bot
added
approved
lgtm
and removed
needs-1-more-lgtm
[LGTM Timeline notifier]Timeline:
|
|
/retest |
1 similar comment
|
/retest |
|
/cherry-pick-invite |
|
@ywqzzy Please accept the invitation then you can push to the cherry-pick pull requests. |
|
/hold |
ti-chi-bot
bot
added
the
do-not-merge/hold
…erry-pick-47804-to-release-7.5
|
/retest |
|
/unhold |
ti-chi-bot
bot
removed
the
do-not-merge/hold
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automated cherry-pick of #47804
What problem does this PR solve?
Issue Number: close #47805
Problem Summary:
The pause ddl job was triggered after the task was successfully completed, and at this point, the task had already been moved to the history table. After resuming the ddl, the table was not queried from the history table, resulting in the framework reopening the task and running it all over again.
What is changed and how it works?
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.