disttask/ddl: fix pause succeed task then run a new task #47804

ywqzzy · 2023-10-19T10:45:44Z

What problem does this PR solve?

Issue Number: close #47805

Problem Summary:
The pause ddl job was triggered after the task was successfully completed, and at this point, the task had already been moved to the history table. After resuming the ddl, the table was not queried from the history table, resulting in the framework reopening the task and running it all over again.

What is changed and how it works?

Use Channel to make sure the pause cmd actually works.
Fetch task from global_task table and history table to make sure the task only run once.

Check List

Tests

Unit test
Integration test
Manual test (add detailed scripts or steps below)
No need to test
- I checked and no code files have been changed.

Side effects

Performance regression: Consumes more CPU
Performance regression: Consumes more Memory
Breaking backward compatibility

Documentation

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

optimize the pause&resume process when a dist task succeed.

tiprow · 2023-10-19T10:46:09Z

Hi @ywqzzy. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

ywqzzy · 2023-10-19T10:53:49Z

/ok-to-test

codecov · 2023-10-19T11:02:04Z

Codecov Report

Merging #47804 (fcb5774) into master (b584055) will increase coverage by 1.0810%.
Report is 1 commits behind head on master.
The diff coverage is 0.0000%.

Additional details and impacted files

@@               Coverage Diff                @@
##             master     #47804        +/-   ##
================================================
+ Coverage   71.7482%   72.8293%   +1.0810%     
================================================
  Files          1400       1424        +24     
  Lines        405579     416129     +10550     
================================================
+ Hits         290996     303064     +12068     
+ Misses        94846      93949       -897     
+ Partials      19737      19116       -621

Flag	Coverage Δ
integration	`42.4868% <0.0000%> (?)`
unit	`71.7249% <0.0000%> (-0.0234%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
dumpling	`53.9913% <ø> (ø)`
parser	`∅ <ø> (∅)`
br	`48.7447% <ø> (-4.2967%)`	⬇️

ywqzzy · 2023-10-19T12:46:47Z

/retest

ywqzzy · 2023-10-20T01:51:58Z

/retest

…ky_pause

ywqzzy · 2023-10-20T02:51:17Z

/test mysql-test

tiprow · 2023-10-20T02:51:51Z

@ywqzzy: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

/test tiprow_fast_test

Use /test all to run all jobs.

In response to this:

/test mysql-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

ywqzzy · 2023-10-20T05:56:22Z

/retest

…ky_pause

D3Hunter · 2023-10-23T09:40:50Z

pkg/ddl/index.go

 	taskManager, err := storage.GetTaskManager()
 	if err != nil {
 		return err
 	}
-	task, err := taskManager.GetGlobalTaskByKey(taskKey)
+	task, err := taskManager.GetGlobalTaskByKeyWithHistory(taskKey)


why paused task moved into history?

why paused task moved into history?

It has possiblity that the dist task was finished but the ddl job was paused.

Benjamin2037

LGTM

ti-chi-bot · 2023-10-23T10:06:35Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Benjamin2037, D3Hunter

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [Benjamin2037,D3Hunter]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

ti-chi-bot · 2023-10-23T10:06:40Z

[LGTM Timeline notifier]

Timeline:

2023-10-23 09:50:58.301971468 +0000 UTC m=+2255455.889081612: ☑️ agreed by D3Hunter.
2023-10-23 10:06:39.097151899 +0000 UTC m=+2256396.684262047: ☑️ agreed by Benjamin2037.

tiprow · 2023-10-23T10:19:04Z

@ywqzzy: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
tiprow_fast_test	`fcb5774`	link	true	`/test tiprow_fast_test`

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

ywqzzy · 2023-10-23T10:33:09Z

/retest

ti-chi-bot · 2023-10-23T10:47:49Z

In response to a cherrypick label: new pull request created to branch release-7.5: #47935.

close pingcap#47805

…7935) close #47805

fix

217f883

ti-chi-bot bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/needs-tests-checked size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed do-not-merge/needs-tests-checked labels Oct 19, 2023

ti-chi-bot bot added do-not-merge/needs-triage-completed and removed do-not-merge/needs-linked-issue labels Oct 19, 2023

ti-chi-bot bot added the ok-to-test Indicates a PR is ready to be tested. label Oct 19, 2023

ywqzzy added 2 commits October 19, 2023 20:01

fix

bab011a

fix

c6047d5

ti-chi-bot bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 19, 2023

ywqzzy changed the title ~~disttask/ddl: fix flaky test~~ disttask/ddl: fix pause succeed task then run 啊 Oct 20, 2023

ywqzzy changed the title ~~disttask/ddl: fix pause succeed task then run 啊~~ disttask/ddl: fix pause succeed task then run a new task Oct 20, 2023

ywqzzy added 3 commits October 20, 2023 10:00

Merge branch 'master' of https://github.com/pingcap/tidb into fix_fla…

e953cb0

…ky_pause

more log

b2fbbeb

fix cancel test

f7da17d

ywqzzy added 2 commits October 20, 2023 14:36

more comments

86d6648

refine test

a3f4746

ti-chi-bot bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 20, 2023

ywqzzy added 2 commits October 20, 2023 15:47

fix

59de5c8

Merge branch 'master' of https://github.com/pingcap/tidb into fix_fla…

fcb5774

…ky_pause

ti-chi-bot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Oct 23, 2023

D3Hunter reviewed Oct 23, 2023

View reviewed changes

D3Hunter approved these changes Oct 23, 2023

View reviewed changes

ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. do-not-merge/needs-triage-completed and removed do-not-merge/needs-triage-completed labels Oct 23, 2023

Benjamin2037 approved these changes Oct 23, 2023

View reviewed changes

ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Oct 23, 2023

ti-chi-bot bot removed the do-not-merge/needs-triage-completed label Oct 23, 2023

ti-chi-bot bot merged commit 0901886 into pingcap:master Oct 23, 2023
11 of 16 checks passed

ti-chi-bot mentioned this pull request Oct 23, 2023

disttask/ddl: fix pause succeed task then run a new task (#47804) #47935

Merged

13 tasks

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Oct 23, 2023

disttask/ddl: fix pause succeed task then run a new task (pingcap#47804)

97a4298

close pingcap#47805

ti-chi-bot bot pushed a commit that referenced this pull request Oct 26, 2023

disttask/ddl: fix pause succeed task then run a new task (#47804) (#4…

c5debb2

…7935) close #47805

ywqzzy mentioned this pull request Oct 30, 2023

Enhance distributed task execution framework #46258

Closed

76 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

disttask/ddl: fix pause succeed task then run a new task #47804

disttask/ddl: fix pause succeed task then run a new task #47804

ywqzzy commented Oct 19, 2023 •

edited

Loading

tiprow bot commented Oct 19, 2023

ywqzzy commented Oct 19, 2023

codecov bot commented Oct 19, 2023 •

edited

Loading

ywqzzy commented Oct 19, 2023

ywqzzy commented Oct 20, 2023

ywqzzy commented Oct 20, 2023

tiprow bot commented Oct 20, 2023

ywqzzy commented Oct 20, 2023

D3Hunter Oct 23, 2023

ywqzzy Oct 23, 2023

Benjamin2037 left a comment

ti-chi-bot bot commented Oct 23, 2023

ti-chi-bot bot commented Oct 23, 2023

tiprow bot commented Oct 23, 2023

ywqzzy commented Oct 23, 2023

ti-chi-bot commented Oct 23, 2023

disttask/ddl: fix pause succeed task then run a new task #47804

disttask/ddl: fix pause succeed task then run a new task #47804

Conversation

ywqzzy commented Oct 19, 2023 • edited Loading

What problem does this PR solve?

What is changed and how it works?

Check List

Release note

tiprow bot commented Oct 19, 2023

ywqzzy commented Oct 19, 2023

codecov bot commented Oct 19, 2023 • edited Loading

Codecov Report

ywqzzy commented Oct 19, 2023

ywqzzy commented Oct 20, 2023

ywqzzy commented Oct 20, 2023

tiprow bot commented Oct 20, 2023

ywqzzy commented Oct 20, 2023

D3Hunter Oct 23, 2023

Choose a reason for hiding this comment

ywqzzy Oct 23, 2023

Choose a reason for hiding this comment

Benjamin2037 left a comment

Choose a reason for hiding this comment

ti-chi-bot bot commented Oct 23, 2023

ti-chi-bot bot commented Oct 23, 2023

[LGTM Timeline notifier]

tiprow bot commented Oct 23, 2023

ywqzzy commented Oct 23, 2023

ti-chi-bot commented Oct 23, 2023

ywqzzy commented Oct 19, 2023 •

edited

Loading

codecov bot commented Oct 19, 2023 •

edited

Loading