planner: disable non-prep plan cache by default #46504
Conversation
ti-chi-bot
bot
added
release-note-none
|
Hi @qw4990. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #46504 +/- ##
================================================
- Coverage 73.3629% 72.6438% -0.7191%
================================================
Files 1303 1330 +27
Lines 394540 400626 +6086
================================================
+ Hits 289446 291030 +1584
- Misses 86687 91123 +4436
- Partials 18407 18473 +66
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
@hawkingrei: adding LGTM is restricted to approvers and reviewers in OWNERS files. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@AilinKid: adding LGTM is restricted to approvers and reviewers in OWNERS files. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@easonn7 PTAL |
|
/approve Non-prepared plan cache is turned off by default, primarily to enhance stability. The plan is to consider enabling non-prepared plan cache by default once it becomes stable in the future. |
|
@XuHuaiyu: adding LGTM is restricted to approvers and reviewers in OWNERS files. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@hawkingrei: adding LGTM is restricted to approvers and reviewers in OWNERS files. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/lgtm |
|
@hawkingrei: adding LGTM is restricted to approvers and reviewers in OWNERS files. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/lgtm |
|
@qw4990: you cannot LGTM your own PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: AilinKid, Defined2014, easonn7, hawkingrei, qw4990, XuHuaiyu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
What problem does this PR solve?
Issue Number: close #36598
Problem Summary: planner: disable non-prep plan cache by default
What is changed and how it works?
Non-Prep plan cache causes some extra memory usage, to make the default behavior more stable, disable this feature by default and let users turn on this feature manually if they need.
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.