Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

performance regression by pr/46504 #46683

Open
tiancaiamao opened this issue Sep 5, 2023 · 3 comments
Open

performance regression by pr/46504 #46683

tiancaiamao opened this issue Sep 5, 2023 · 3 comments
Labels
type/enhancement The issue or PR belongs to an enhancement.

Comments

@tiancaiamao
Copy link
Contributor

Enhancement

Ref #25754
2023.9.5
See http://www.zenlife.tk:18081/alloc

image

cd session;
go test -tags intest  -bench BenchmarkIntegerIndexLookup -run XXX -benchmem;

Before vs After:

BenchmarkIntegerIndexLookup-16              3301            413728 ns/op          118861 B/op       969 allocs/op
BenchmarkIntegerIndexLookup-16              2366            523089 ns/op          154557 B/op       1564 allocs/op
@tiancaiamao tiancaiamao added the type/enhancement The issue or PR belongs to an enhancement. label Sep 5, 2023
@hawkingrei
Copy link
Member

It is a sad story. We worry about OOM after enabling the planner cache. so we decided to disable the planner cache when to GA the planner cache.

@qw4990
Copy link
Contributor

qw4990 commented Sep 5, 2023

It's caused by #46504. But it's expected, we disable non-prepare plan cache to ensure stability.

@tiancaiamao
Copy link
Contributor Author

From the picture, we can see the historial data.
I just wonder, why it regression so much when it's disable ... whereas no such obvious improvement when it's introduced.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Development

No branches or pull requests

3 participants