Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

planner: Move the Selectivity function from the stats package into cardinality package #46383

Merged
merged 7 commits into from
Aug 24, 2023
Merged

planner: Move the Selectivity function from the stats package into cardinality package #46383

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
8b4d086
fixup
qw4990 Aug 24, 2023
e94af18
fixup
qw4990 Aug 24, 2023
cb088e2
fixup
qw4990 Aug 24, 2023
2abe171
fixup
qw4990 Aug 24, 2023
663e0b9
fixup
qw4990 Aug 24, 2023
90b7516
fixup
qw4990 Aug 24, 2023
44d4653
Merge remote-tracking branch 'upstream/master' into ce-decoupling-2
qw4990 Aug 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fixup
  • Loading branch information
@qw4990
qw4990 committed Aug 24, 2023
commit 663e0b94f9c51f5c8f84f25ebd8c5d4e06b1ab3f
15 changes: 14 additions & 1 deletion planner/cardinality/histogram.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,17 @@
// Copyright 2023 PingCAP, Inc.
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.

package cardinality
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add license header.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remember to run the make bazel_prepare.


import (
Expand Down Expand Up @@ -103,7 +117,6 @@ type countByRangeFunc = func(sessionctx.Context, int64, []*ranger.Range) (float6

// newHistogramBySelectivity fulfills the content of new histogram by the given selectivity result.
// TODO: remove this function after removing docs.pingcap.com/tidb/stable/system-variables#tidb_optimizer_selectivity_level.
// Also, there're redundant calculation with Selectivity(). We need to reduce it too.
func newHistogramBySelectivity(sctx sessionctx.Context, histID int64, oldHist, newHist *statistics.Histogram, ranges []*ranger.Range, cntByRangeFunc countByRangeFunc) error {
cntPerVal := int64(oldHist.AvgCountPerNotNullValue(int64(oldHist.TotalRowCount())))
var totCnt int64
Expand Down