planner: Move the Selectivity function from the stats package into cardinality package #46383
Conversation
ti-chi-bot
bot
added
release-note-none
qw4990
added
sig/planner
|
Hi @qw4990. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
| @@ -0,0 +1,194 @@ | |||
| package cardinality | |||
There was a problem hiding this comment.
remember to run the make bazel_prepare.
| if !ok { | ||
| continue | ||
| } | ||
| newCol := &statistics.Column{ |
There was a problem hiding this comment.
We can add NewColumn for it.
There was a problem hiding this comment.
That's exactly what I want to do later on... Use a standard NewFunc to create these structures.
|
/ok-to-test |
ti-chi-bot
bot
added
approved
needs-1-more-lgtm
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #46383 +/- ##
================================================
- Coverage 73.3921% 72.7076% -0.6845%
================================================
Files 1290 1312 +22
Lines 393530 399724 +6194
================================================
+ Hits 288820 290630 +1810
- Misses 86351 90656 +4305
- Partials 18359 18438 +79
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hawkingrei, hi-rustin The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ti-chi-bot
bot
added
lgtm
and removed
needs-1-more-lgtm
[LGTM Timeline notifier]Timeline:
|
What problem does this PR solve?
Issue Number: ref #46358
Problem Summary: Move the Selectivity function from the stats package into cardinality package
What is changed and how it works?
No logical change, just some code movement.
Follow with #46359
Move the Selectivity function from the stats package.
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.