Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: update client-go to avoid calculating histogram labels (#36979) #36984

Closed

Conversation

ti-srebot
Copy link
Contributor

@ti-srebot ti-srebot commented Aug 9, 2022

cherry-pick #36979 to release-6.2
You can switch your code base to this Pull Request by using git-extras:

# In tidb repo:
git pr https://github.com/pingcap/tidb/pull/36984

After apply modifications, you can push your change to this PR via:

git push git@github.com:ti-srebot/tidb.git pr/36984:release-6.2-ae2ebe0e3113

What problem does this PR solve?

Issue Number: ref #36955

Problem Summary:

See tikv/client-go#563. The histogram cache does not take effect due to a mistake, causing performance issues due to frequent histogram labels generation.

What is changed and how it works?

Update client-go to fix the cache issue.

Check List

Tests

  • Manual test (add detailed scripts or steps below)

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-chi-bot
Copy link
Member

@ti-srebot: This cherry pick PR is for a release branch and has not yet been approved by release team.
Adding the do-not-merge/cherry-pick-not-approved label.

To merge this cherry pick, it must first be approved by the collaborators.

AFTER it has been approved by collaborators, please ping the release team in a comment to request a cherry pick review.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Aug 9, 2022
@ti-srebot ti-srebot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. type/6.2-cherry-pick labels Aug 9, 2022
@ti-chi-bot ti-chi-bot removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Aug 9, 2022
@ti-srebot ti-srebot requested review from hawkingrei and you06 August 9, 2022 05:56
@ti-srebot
Copy link
Contributor Author

@sticnarf you're already a collaborator in bot's repo.

@sticnarf
Copy link
Contributor

sticnarf commented Aug 9, 2022

Use #36978 instead

@sticnarf sticnarf closed this Aug 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/cherry-pick-not-approved release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. type/6.2-cherry-pick
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants