-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
*: update client-go to avoid calculating histogram labels #36979
Conversation
Signed-off-by: Yilin Chen <sticnarf@gmail.com>
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/4e25a90ed93402062cc98ef34ee3abdaa77ac1a2 |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 7b634cd
|
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
cherry pick to release-6.2 in PR #36984 |
TiDB MergeCI notify🔴 Bad News! New failing [1] after this pr merged.
|
What problem does this PR solve?
Issue Number: ref #36955
Problem Summary:
See tikv/client-go#563. The histogram cache does not take effect due to a mistake, causing performance issues due to frequent histogram labels generation.
What is changed and how it works?
Update client-go to fix the cache issue.
Check List
Tests
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.