-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
executor, statistics: analyze use MaxUint64 ts to read data #35232
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/c5d9e0daec244b6f7b577c4a8d623725bb7f3495 |
fcd1279
to
18c29e8
Compare
/run-mysql-test |
1 similar comment
/run-mysql-test |
/run-mysql-test |
/build |
/build |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: e1811dd
|
/run-unit-test |
/run-mysql-test |
/run-check_dev_2 |
TiDB MergeCI notify✅ Well Done! New fixed [1] after this pr merged.
|
In response to a cherrypick label: new pull request created to branch |
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
What problem does this PR solve?
Issue Number: close #35233
Problem Summary:
Snapshot analyze may meet
GC life time is shorter than transaction duration
or block GC.What is changed and how it works?
Analyze use MaxUint64 ts to read data. At the end of analyze, we still incrementally update modify_count and count, which may lead to overestimation of modify_count and count. When there are lots of updates during the analyze, the overestimation help trigger auto analyze, which is considered better than underestimation(directly setting modify_count = 0 and count = analyze_row_count can lead to underestimation).
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.