-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
analyze use MaxUint64 ts to read data #35233
Comments
But the original issue of #24575 has concerns on overestimation of modify_count, maybe add another |
Yes. We switch back to read the latest data rather than certain snapshot because analyze does't require strong data consistency and analyze on snapshot may bring some problems(auto analyze blocks gc or long-time auto analyze fails) more severe than inaccurate |
Enhancement
#24575 makes analyze read data on snapshot. Combined with incremental update of modify_count and count at the end of analyze, we can get a more accurate modify_count especially when lots of updates happen during the long time analyze. However, long-time snapshot analyze can throw error
GC life time is shorter than transaction duration
(#29862) or block GC(#35062). Considering analyze doesn't require strong data consistency, we hope to change back to use MaxUint64 ts to read data in analyze.The text was updated successfully, but these errors were encountered: