Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

config, sysvar: fix the missing config of plugins. (#34926) #34933

Merged
merged 3 commits into from
May 26, 2022
Merged

config, sysvar: fix the missing config of plugins. (#34926) #34933

merged 3 commits into from
May 26, 2022

Conversation

ti-srebot
Copy link
Contributor

@ti-srebot ti-srebot commented May 25, 2022 •
edited
Loading

cherry-pick #34926 to release-6.1
You can switch your code base to this Pull Request by using git-extras:

# In tidb repo:
git pr https://github.com/pingcap/tidb/pull/34933

After apply modifications, you can push your change to this PR via:

git push git@github.com:ti-srebot/tidb.git pr/34933:release-6.1-3ac98d38af1a

What problem does this PR solve?

Issue Number: close #34917

Problem Summary:

When the TiDB cluster upgrades to v6.1.0, the config about plugin is missed.

What is changed and how it works?

The bug is caused by the wrong convertion of [plugin] section in config.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@CbcWestwolf @ti-srebot
cherry pick pingcap#34926 to release-6.1
7c4b79b 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented May 25, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • morgo
  • zimulala

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/cherry-pick-not-approved do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels May 25, 2022
@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels May 25, 2022
@ti-srebot ti-srebot mentioned this pull request May 25, 2022
Merged
12 tasks
@ti-srebot ti-srebot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/6.1-cherry-pick labels May 25, 2022
@ti-srebot
Copy link
Contributor Author

@CbcWestwolf please accept the invitation then you can push to the cherry-pick pull requests. Comment with /cherry-pick-invite if the invitation is expired.
https://github.com/ti-srebot/tidb/invitations

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label May 25, 2022
@sre-bot
Copy link
Contributor

sre-bot commented May 25, 2022 •
edited
Loading

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/a364e8c40796cfd47f716361e2d47444fdf0fcd8

@VelocityLight VelocityLight added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels May 25, 2022
zimulala
zimulala approved these changes May 26, 2022
View reviewed changes
Copy link
Contributor

@zimulala zimulala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels May 26, 2022
@windtalker
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 7c4b79b

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label May 26, 2022
@windtalker
Copy link
Contributor

/run-mysql-test

1 similar comment
@CbcWestwolf
Copy link
Member

/run-mysql-test

@ti-chi-bot ti-chi-bot merged commit bc0bf11 into pingcap:release-6.1 May 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@morgo morgo morgo approved these changes

@zimulala zimulala zimulala approved these changes

@bb7133 bb7133 Awaiting requested review from bb7133

Assignees

@CbcWestwolf CbcWestwolf

Labels
cherry-pick-approved Cherry pick PR approved by release team. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/6.1-cherry-pick
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@ti-srebot @ti-chi-bot @sre-bot @windtalker @CbcWestwolf @morgo @zimulala @VelocityLight