Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tiup plugin config is changed #34917

Closed
aytrack opened this issue May 24, 2022 · 0 comments · Fixed by #34926
Closed

tiup plugin config is changed #34917

aytrack opened this issue May 24, 2022 · 0 comments · Fixed by #34926
Assignees
Labels
affects-6.1 component/deployment priority/release-blocker This issue blocks a release. Please solve it ASAP. severity/major sig/sql-infra SIG: SQL Infra type/bug The issue is confirmed as a bug.

Comments

@aytrack
Copy link
Contributor

aytrack commented May 24, 2022

Bug Report

Please answer these questions before submitting your issue. Thanks!

1. Minimal reproduce step (Required)

  1. deploy a v5.4.1 cluster with plugin, which config like
plugin.dir: "path/to/plugin"
plugin.load: "whitelist-1,audit-1"
  1. upgrade this cluster to v6.1.0 without edit the config
  2. check the plugins status show plugins

2. What did you expect to see? (Required)

  1. after upgrade, the plugin will work well

3. What did you see instead (Required)

  1. the plugin not load

#33279 changed the config to instance. you need to change the config to

instance.plugin_dir: "path/to/plugin"
instance.plugin_load: "audit-1,whitelist-1"

4. What is your TiDB version? (Required)

mysql root@172.16.4.131:(none)> select tidb_version()\G
***************************[ 1. row ]***************************
tidb_version() | Release Version: v6.1.0
Edition: Community
Git Commit Hash: f87623664f5417497cc828e03079762bee8b0b5b
Git Branch: heads/refs/tags/v6.1.0
UTC Build Time: 2022-05-23 10:12:19
GoVersion: go1.18.2
Race Enabled: false
TiKV Min Version: v3.0.0-60965b006877ca7234adaced7890d7b029ed1306
Check Table Before Drop: false
@aytrack aytrack added type/bug The issue is confirmed as a bug. sig/sql-infra SIG: SQL Infra component/deployment severity/major labels May 24, 2022
@ti-chi-bot ti-chi-bot added may-affects-4.0 This bug maybe affects 4.0.x versions. may-affects-5.0 This bug maybe affects 5.0.x versions. may-affects-5.1 This bug maybe affects 5.1.x versions. may-affects-5.2 This bug maybe affects 5.2.x versions. may-affects-5.3 This bug maybe affects 5.3.x versions. may-affects-5.4 This bug maybe affects 5.4.x versions. may-affects-6.0 may-affects-6.1 labels May 24, 2022
@aytrack aytrack removed may-affects-4.0 This bug maybe affects 4.0.x versions. may-affects-5.1 This bug maybe affects 5.1.x versions. may-affects-5.2 This bug maybe affects 5.2.x versions. may-affects-5.3 This bug maybe affects 5.3.x versions. may-affects-5.4 This bug maybe affects 5.4.x versions. may-affects-5.0 This bug maybe affects 5.0.x versions. may-affects-6.0 labels May 24, 2022
@bb7133 bb7133 added the priority/release-blocker This issue blocks a release. Please solve it ASAP. label May 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
affects-6.1 component/deployment priority/release-blocker This issue blocks a release. Please solve it ASAP. severity/major sig/sql-infra SIG: SQL Infra type/bug The issue is confirmed as a bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants