Skip to content

ddl: improve multi-schema-change log#33560

Closed
Defined2014 wants to merge 35 commits into
pingcap:masterfrom
tangenta:improve-log
Closed

ddl: improve multi-schema-change log#33560
Defined2014 wants to merge 35 commits into
pingcap:masterfrom
tangenta:improve-log

Conversation

@Defined2014

Copy link
Copy Markdown
Contributor

What problem does this PR solve?

Issue Number: ref #14

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

tangenta and others added 30 commits March 2, 2022 16:21
support multi-schema change for add columns
* ddl: check add position before create doDDLJob()

* ddl: fix go fmt
* check index

* ddl, parser: support check addIndex and dropIndex
* support multi-schema-change for drop index

* fix integration tests
@Defined2014 Defined2014 requested a review from tangenta March 29, 2022 09:33
@ti-chi-bot

Copy link
Copy Markdown
Member

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot

Copy link
Copy Markdown
Member

[FORMAT CHECKER NOTIFICATION]

Notice: To remove the do-not-merge/needs-linked-issue label, please provide the linked issue number on one line in the PR body, for example: Issue Number: close #123 or Issue Number: ref #456.

📖 For more info, you can check the "Contribute Code" section in the development guide.

@ti-chi-bot ti-chi-bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Mar 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/needs-linked-issue do-not-merge/needs-triage-completed release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants