Skip to content

ddl: reimplement the error handling in multi-schema change#31

Merged
Defined2014 merged 3 commits into
multi-schema-changefrom
msc-reimpl-err
Mar 16, 2022
Merged

ddl: reimplement the error handling in multi-schema change#31
Defined2014 merged 3 commits into
multi-schema-changefrom
msc-reimpl-err

Conversation

@tangenta

@tangenta tangenta commented Mar 16, 2022

Copy link
Copy Markdown
Owner

What problem does this PR solve?

Issue Number: close #28

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

Comment thread ddl/column.go Outdated
Comment thread ddl/index.go Outdated
Co-authored-by: Hangjie Mo <mohangjie1995@gmail.com>

@Defined2014 Defined2014 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Defined2014 Defined2014 merged commit ec0104c into multi-schema-change Mar 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Reimplement the error handling for multi-schema change

2 participants