planner: add missing column for Apply convert to Join (#27246)

[ti-srebot]

cherry-pick #27246 to release-5.0
You can switch your code base to this Pull Request by using git-extras:

# In tidb repo:
git pr https://github.com/pingcap/tidb/pull/27283

After apply modifications, you can push your change to this PR via:

git push git@github.com:ti-srebot/tidb.git pr/27283:release-5.0-1c6c5483341c

---

What problem does this PR solve?

Issue Number: close #27233

Problem Summary:
In master 5ae87ca, the aggregate function missing a column.
In this case, count distinct function should have 2 args col1 and col2.

[tidb]> desc SELECT col2 FROM PK_S_MULTI_31 AS T1 WHERE (SELECT count(DISTINCT COL1, COL2) FROM PK_S_MULTI_31 AS T2 WHERE T2.COL1>T1.COL1)>2 ;
+-----------------------------------+--------------+-----------+-------------------------------------+--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+
| id                                | estRows      | task      | access object                       | operator info                                                                                                                                                                        |
+-----------------------------------+--------------+-----------+-------------------------------------+--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+
| Projection_10                     | 0.80         | root      |                                     | test.pk_s_multi_31.col2                                                                                                                                                              |
| └─Selection_11                    | 0.80         | root      |                                     | gt(Column#7, 2)                                                                                                                                                                      |
|   └─HashAgg_12                    | 1.00         | root      |                                     | group by:test.pk_s_multi_31.col1, test.pk_s_multi_31.col2, funcs:firstrow(test.pk_s_multi_31.col2)->test.pk_s_multi_31.col2, funcs:count(distinct test.pk_s_multi_31.col1)->Column#7 |
|     └─HashJoin_14                 | 100000000.00 | root      |                                     | CARTESIAN left outer join, other cond:gt(test.pk_s_multi_31.col1, test.pk_s_multi_31.col1)                                                                                           |
|       ├─TableReader_21(Build)     | 10000.00     | root      |                                     | data:TableFullScan_20                                                                                                                                                                |
|       │ └─TableFullScan_20        | 10000.00     | cop[tikv] | table:T2                            | keep order:false, stats:pseudo                                                                                                                                                       |
|       └─IndexReader_19(Probe)     | 10000.00     | root      |                                     | index:IndexFullScan_18                                                                                                                                                               |
|         └─IndexFullScan_18        | 10000.00     | cop[tikv] | table:T1, index:PRIMARY(COL1, COL2) | keep order:false, stats:pseudo                                                                                                                                                       |
+-----------------------------------+--------------+-----------+-------------------------------------+--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+

What is changed and how it works?

Proposal: xxx

What's Changed:
Aggregate maybe have many args, so we should also consider when converting Apply to Join.

In this pr, the distinct count will have two args.

[tidb]> desc SELECT col2 FROM PK_S_MULTI_31 AS T1 WHERE (SELECT count(DISTINCT COL1, COL2) FROM PK_S_MULTI_31 AS T2 WHERE T2.COL1>T1.COL1)>2 ;
+-----------------------------------+----------+-----------+-------------------------------------+---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+
| id                                | estRows  | task      | access object                       | operator info                                                                                                                                                                                                 |
+-----------------------------------+----------+-----------+-------------------------------------+---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+
| Projection_10                     | 0.80     | root      |                                     | test.pk_s_multi_31.col2                                                                                                                                                                                       |
| └─Selection_11                    | 0.80     | root      |                                     | gt(Column#7, 2)                                                                                                                                                                                               |
|   └─HashAgg_12                    | 1.00     | root      |                                     | group by:test.pk_s_multi_31.col1, test.pk_s_multi_31.col2, funcs:firstrow(test.pk_s_multi_31.col2)->test.pk_s_multi_31.col2, funcs:count(distinct test.pk_s_multi_31.col1, test.pk_s_multi_31.col2)->Column#7 |
|     └─HashJoin_14                 | 10404.00 | root      |                                     | CARTESIAN left outer join, other cond:gt(test.pk_s_multi_31.col1, test.pk_s_multi_31.col1)                                                                                                                    |
|       ├─IndexReader_23(Build)     | 102.00   | root      |                                     | index:IndexFullScan_22                                                                                                                                                                                        |
|       │ └─IndexFullScan_22        | 102.00   | cop[tikv] | table:T2, index:PRIMARY(COL1, COL2) | keep order:false, stats:pseudo                                                                                                                                                                                |
|       └─IndexReader_19(Probe)     | 102.00   | root      |                                     | index:IndexFullScan_18                                                                                                                                                                                        |
|         └─IndexFullScan_18        | 102.00   | cop[tikv] | table:T1, index:PRIMARY(COL1, COL2) | keep order:false, stats:pseudo                                                                                                                                                                                |
+-----------------------------------+----------+-----------+-------------------------------------+---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+
8 rows in set, 1 warning (0.001 sec)

How it Works:

Check List

Tests

• Unit test
• Integration test
• Manual test (add detailed scripts or steps below)
• No code

Side effects

• Performance regression: Consumes more CPU
• Performance regression: Consumes more Memory
• Breaking backward compatibility

Documentation

• Affects user behaviors
• Contains syntax changes
• Contains variable changes
• Contains experimental features
• Changes MySQL compatibility

Release note

planner: add missing column for Apply convert to Join

[ti-chi-bot]

[REVIEW NOTIFICATION]

This pull request has been approved by:

• XuHuaiyu
• lzmhhh123

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

[ti-srebot]

/run-all-tests

[ti-srebot]

@wshwsh12 you're already a collaborator in bot's repo.

[wshwsh12]

Also included #26968

[XuHuaiyu]

LGTM

[wshwsh12]

/merge

[ti-chi-bot]

This pull request has been accepted and is ready to merge.

Commit hash: 10a2bdf

[zhouqiang-cl]

/merge

[ti-chi-bot]

@ti-srebot: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.