-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
planner: add missing column for Apply convert to Join #27246
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
In release 4.0, the distinct count missing both distinct flag and a column, and the result is correct by mistake..
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 8cc6252
|
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
cherry pick to release-4.0 in PR #27282 |
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
cherry pick to release-5.0 in PR #27283 |
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
cherry pick to release-5.1 in PR #27284 |
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
cherry pick to release-5.2 in PR #27285 |
What problem does this PR solve?
Issue Number: close #27233
Problem Summary:
In master 5ae87ca, the aggregate function missing a column.
In this case, count distinct function should have 2 args col1 and col2.
What is changed and how it works?
Proposal: xxx
What's Changed:
Aggregate maybe have many args, so we should also consider when converting Apply to Join.
In this pr, the distinct count will have two args.
How it Works:
Check List
Tests
Side effects
Documentation
Release note