Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

store/tikv: interate all keys in relocate of batch-get #25429

Merged
merged 4 commits into from
Jun 15, 2021
Merged

store/tikv: interate all keys in relocate of batch-get #25429

merged 4 commits into from
Jun 15, 2021

Conversation

youjiali1995
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #xxx

Problem Summary:

#25416 changes the order of keys in batch-get, but some codes rely on the order of keys.

What is changed and how it works?

Proposal: xxx

What's Changed:

Instead of sorting, iterate all keys in relocate.

Related changes

  • Need to cherry-pick to the release branch

Check List

Tests

  • No code

Side effects

Release note

  • No release note.

@youjiali1995 youjiali1995 requested review from lysu and sticnarf June 15, 2021 08:36
@ti-chi-bot ti-chi-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jun 15, 2021
@youjiali1995
Copy link
Contributor Author

/run-all-tests

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jun 15, 2021
@youjiali1995
Copy link
Contributor Author

/run-check_dev_2

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • lysu
  • sticnarf

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jun 15, 2021
@youjiali1995
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 2d3e02b

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 15, 2021
@youjiali1995
Copy link
Contributor Author

/run-sqllogic-test-1

@youjiali1995
Copy link
Contributor Author

/merge

@youjiali1995
Copy link
Contributor Author

/run-common-test

@youjiali1995
Copy link
Contributor Author

/run-integration-common-test

@ti-chi-bot ti-chi-bot merged commit c62adba into pingcap:master Jun 15, 2021
@ti-srebot ti-srebot mentioned this pull request Jun 15, 2021
Merged
@ti-srebot
Copy link
Contributor

cherry pick to release-5.1 in PR #25434

@youjiali1995 youjiali1995 deleted the fix-batch-get-relocate-v2 branch June 15, 2021 09:22
youjiali1995 added a commit to ti-srebot/tidb that referenced this pull request Jun 15, 2021
@youjiali1995
cherry pick pingcap#25429 to release-5.1
b2d2156 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
Signed-off-by: youjiali1995 <zlwgx1023@gmail.com>
zhouqiang-cl pushed a commit that referenced this pull request Jun 15, 2021
@ti-srebot
cherry pick #25429 to release-5.1 (#25434)
befa712 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@disksing disksing mentioned this pull request Jun 16, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sticnarf sticnarf sticnarf approved these changes

@lysu lysu lysu approved these changes

Assignees
No one assigned
Labels
needs-cherry-pick-release-5.1 sig/transaction SIG:Transaction size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@youjiali1995 @ti-chi-bot @ti-srebot @lysu @sticnarf