store/tikv: sort keys in batch get

[youjiali1995]

Signed-off-by: youjiali1995 zlwgx1023@gmail.com

What problem does this PR solve?

Issue Number: close ##25412
Problem Summary:

Batch-get assumes batchKeys is in order which is wrong.

What is changed and how it works?

Proposal: xxx

What's Changed:

Make keys in order.

Related changes

• Need to cherry-pick to the release branch

Check List

Tests

• No code

Side effects

Release note

• No release note.

[sticnarf]

LGTM

[ti-chi-bot]

[REVIEW NOTIFICATION]

This pull request has been approved by:

• lysu
• sticnarf

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

[youjiali1995]

/merge

[ti-chi-bot]

This pull request has been accepted and is ready to merge.

Commit hash: ae5c29a

[youjiali1995]

/run-check_dev_2

[youjiali1995]

[2021-06-15T06:58:10.801Z] ----------------------------------------------------------------------
[2021-06-15T06:58:10.801Z] FAIL: analyze_test.go:55: testSuite1.TestAnalyzePartition
[2021-06-15T06:58:10.801Z] 
[2021-06-15T06:58:10.801Z] analyze_test.go:57:
[2021-06-15T06:58:10.801Z]     testkit.WithPruneMode(tk, variable.Static, func() {
[2021-06-15T06:58:10.801Z]         tk.MustExec("use test")
[2021-06-15T06:58:10.801Z]         tk.MustExec("drop table if exists t")
[2021-06-15T06:58:10.801Z]         tk.MustExec("set @@tidb_analyze_version=2")
[2021-06-15T06:58:10.801Z]         createTable := `CREATE TABLE t (a int, b int, c varchar(10), primary key(a), index idx(b))
[2021-06-15T06:58:10.801Z]     PARTITION BY RANGE ( a ) (
[2021-06-15T06:58:10.802Z]     		PARTITION p0 VALUES LESS THAN (6),
[2021-06-15T06:58:10.802Z]     		PARTITION p1 VALUES LESS THAN (11),
[2021-06-15T06:58:10.802Z]     		PARTITION p2 VALUES LESS THAN (16),
[2021-06-15T06:58:10.802Z]     		PARTITION p3 VALUES LESS THAN (21)
[2021-06-15T06:58:10.802Z]     )`
[2021-06-15T06:58:10.802Z]         tk.MustExec(createTable)
[2021-06-15T06:58:10.802Z]         for i := 1; i < 21; i++ {
[2021-06-15T06:58:10.802Z]             tk.MustExec(fmt.Sprintf(`insert into t values (%d, %d, "hello")`, i, i))
[2021-06-15T06:58:10.802Z]         }
[2021-06-15T06:58:10.802Z]         tk.MustExec("analyze table t")
[2021-06-15T06:58:10.802Z] 
[2021-06-15T06:58:10.802Z]         is := tk.Se.(sessionctx.Context).GetInfoSchema().(infoschema.InfoSchema)
[2021-06-15T06:58:10.802Z]         table, err := is.TableByName(model.NewCIStr("test"), model.NewCIStr("t"))
[2021-06-15T06:58:10.802Z]         c.Assert(err, IsNil)
[2021-06-15T06:58:10.802Z]         pi := table.Meta().GetPartitionInfo()
[2021-06-15T06:58:10.802Z]         c.Assert(pi, NotNil)
[2021-06-15T06:58:10.802Z]         do, err := session.GetDomain(s.store)
[2021-06-15T06:58:10.802Z]         c.Assert(err, IsNil)
[2021-06-15T06:58:10.802Z]         handle := do.StatsHandle()
[2021-06-15T06:58:10.802Z]         for _, def := range pi.Definitions {
[2021-06-15T06:58:10.802Z]             statsTbl := handle.GetPartitionStats(table.Meta(), def.ID)
[2021-06-15T06:58:10.802Z]             c.Assert(statsTbl.Pseudo, IsFalse)
[2021-06-15T06:58:10.802Z]             c.Assert(len(statsTbl.Columns), Equals, 3)
[2021-06-15T06:58:10.802Z]             c.Assert(len(statsTbl.Indices), Equals, 1)
[2021-06-15T06:58:10.802Z]             for _, col := range statsTbl.Columns {
[2021-06-15T06:58:10.802Z]                 c.Assert(col.Len()+col.Num(), Greater, 0)
[2021-06-15T06:58:10.802Z]             }
[2021-06-15T06:58:10.802Z]             for _, idx := range statsTbl.Indices {
[2021-06-15T06:58:10.802Z]                 c.Assert(idx.Len()+idx.Num(), Greater, 0)
[2021-06-15T06:58:10.802Z]             }
[2021-06-15T06:58:10.802Z]         }
[2021-06-15T06:58:10.802Z] 
[2021-06-15T06:58:10.802Z]         tk.MustExec("drop table t")
[2021-06-15T06:58:10.802Z]         tk.MustExec(createTable)
[2021-06-15T06:58:10.802Z]         for i := 1; i < 21; i++ {
[2021-06-15T06:58:10.802Z]             tk.MustExec(fmt.Sprintf(`insert into t values (%d, %d, "hello")`, i, i))
[2021-06-15T06:58:10.802Z]         }
[2021-06-15T06:58:10.802Z]         tk.MustExec("alter table t analyze partition p0")
[2021-06-15T06:58:10.802Z]         is = tk.Se.(sessionctx.Context).GetInfoSchema().(infoschema.InfoSchema)
[2021-06-15T06:58:10.802Z]         table, err = is.TableByName(model.NewCIStr("test"), model.NewCIStr("t"))
[2021-06-15T06:58:10.802Z]         c.Assert(err, IsNil)
[2021-06-15T06:58:10.802Z]         pi = table.Meta().GetPartitionInfo()
[2021-06-15T06:58:10.802Z]         c.Assert(pi, NotNil)
[2021-06-15T06:58:10.802Z] 
[2021-06-15T06:58:10.802Z]         for i, def := range pi.Definitions {
[2021-06-15T06:58:10.802Z]             statsTbl := handle.GetPartitionStats(table.Meta(), def.ID)
[2021-06-15T06:58:10.802Z]             if i == 0 {
[2021-06-15T06:58:10.802Z]                 c.Assert(statsTbl.Pseudo, IsFalse)
[2021-06-15T06:58:10.802Z]                 c.Assert(len(statsTbl.Columns), Equals, 3)
[2021-06-15T06:58:10.802Z]                 c.Assert(len(statsTbl.Indices), Equals, 1)
[2021-06-15T06:58:10.802Z]             } else {
[2021-06-15T06:58:10.802Z]                 c.Assert(statsTbl.Pseudo, IsTrue)
[2021-06-15T06:58:10.802Z]             }
[2021-06-15T06:58:10.802Z]         }
[2021-06-15T06:58:10.802Z]     })
[2021-06-15T06:58:10.802Z] /home/jenkins/agent/workspace/tidb_ghpr_check_2/go/src/github.com/pingcap/tidb/util/testkit/testkit.go:217:
[2021-06-15T06:58:10.802Z]     tk.c.Assert(err, check.IsNil, check.Commentf("sql:%s, %v, error stack %v", sql, args, errors.ErrorStack(err)))
[2021-06-15T06:58:10.802Z] ... value *errors.fundamental = analyze worker panic ("analyze worker panic")
[2021-06-15T06:58:10.802Z] ... sql:alter table t analyze partition p0, [], error stack analyze worker panic
[2021-06-15T06:58:10.802Z] github.com/pingcap/tidb/executor.init
[2021-06-15T06:58:10.802Z] 	/home/jenkins/agent/workspace/tidb_ghpr_check_2/go/src/github.com/pingcap/tidb/executor/analyze.go:247
[2021-06-15T06:58:10.802Z] runtime.doInit
[2021-06-15T06:58:10.802Z] 	/usr/local/go/src/runtime/proc.go:6309
[2021-06-15T06:58:10.802Z] runtime.doInit
[2021-06-15T06:58:10.802Z] 	/usr/local/go/src/runtime/proc.go:6286
[2021-06-15T06:58:10.802Z] runtime.main
[2021-06-15T06:58:10.802Z] 	/usr/local/go/src/runtime/proc.go:208
[2021-06-15T06:58:10.802Z] runtime.goexit
[2021-06-15T06:58:10.802Z] 	/usr/local/go/src/runtime/asm_amd64.s:1371

[youjiali1995]

/run-integration-common-test

[ti-srebot]

cherry pick to release-5.1 in PR #25417