structure: fix err check #23003
structure: fix err check #23003
Conversation
ti-chi-bot
added
do-not-merge/work-in-progress
ti-chi-bot
removed
the
do-not-merge/work-in-progress
structure/structure_test.go
Outdated
| defer txn.Rollback() | ||
| defer func() { | ||
| // to fix: invalid txn | ||
| err = txn.Rollback() |
There was a problem hiding this comment.
We commit this txn at the end of this function. So I think we can remove this code.
structure/structure_test.go
Outdated
| defer txn.Rollback() | ||
| defer func() { | ||
| err = txn.Rollback() | ||
| // to fix: test for invalid txn |
There was a problem hiding this comment.
Please check whether we need to remove this code.
structure/structure_test.go
Outdated
| defer txn.Rollback() | ||
| defer func() { | ||
| // to fix: invalid transaction | ||
| err := txn.Rollback() |
ti-chi-bot
added
size/XS
|
/lgtm |
|
@zz-jason: Please use If you have approved this PR, please ignore this reply. This reply is being used as a temporary reply during the migration of the new bot and will be removed on April 1. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
|
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by writing |
ti-chi-bot
added
status/LGT2
|
/merge |
|
@zz-jason: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests You only need to trigger If you have any questions about the PR merge process, please refer to pr process. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
|
This pull request has been accepted and is ready to merge. Commit hash: 956ce9d
|
ti-chi-bot
added
the
status/can-merge
|
@Tjianke: Your PR was out of date, I have automatically updated it for you. At the same time I will also trigger all tests for you: /run-all-tests Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
|
/run-all-tests |
What problem does this PR solve?
Issue Number: #22979
Problem Summary:
What is changed and how it works?
What's Changed: added err check
Check List
Tests
Release note