Make some linters really happy

[zimulala]

Description

Currently, we use "golangci-lint" to execute some linters, but due to some reasons, the entire project code may not really pass some necessary linters.
This issue is for everyone to work together to pass some necessary linters for this project. The specific parameters that need to be supported are shown in the task list below.

Related Information

• golangci-lint
• This Makefile: remove linters #22978 intends to revert linters that have not yet passed.
• Refer to code for the specific parameter addition method

Task List

• --enable=deadcode
• --enable=errcheck
• --enable=gosimple
• --enable=staticcheck
• --enable=typecheck
• --enable=unused
• --enable=varcheck
• --enable=structcheck

We can cooperate in handling this issue by picking up the corresponding parameters.

[zimulala]

Relate to #22754

[Tjianke]

I would like to try on errcheck part.

[disksing]

I'll take structcheck.

[Willendless]

I'll try --enable=varcheck.

[tisonkun]

I would like to try on errcheck part.

@Tjianke How is it going? I'll start the development this weekend if no activity yet.

[Tjianke]

I would like to try on errcheck part.

@Tjianke How is it going? I'll start the development this weekend if no activity yet.

Merged PRs on most packages, 3 PRs still waiting for review.

[tisonkun]

Thanks! I can see

#22994
#23002
#23001

[tisonkun]

@zimulala @disksing unused is enabled by the whole #23013 . Please update the description of this issue.

[disksing]

@tisonkun cool, thanks!

[tisonkun]

gosimple is enabled by #24617

[dveeden]

The tasks in the description that are still open are the onces for staticcheck and errcheck. However looking at the Makefile it looks like we already run those outside of golangci-lint. And there is tools/check/errcheck_excludes.txt and staticcheck.conf to configure those.

So what's left to do here? Change the Makefile to run these under golangci-lint? Remove excludes from the configs? Include more tests? golangci-lint also has many more tests that are not enabled by default.

[disksing]

I think it would be a good idea to use golangci-lint to run all tests. By running all linters from a single entry point, we can more easily run all linters from a single command, and also better align parameters such as timeout.

[xxchan]

Is this issue done?

[dveeden]

Is this issue done?

As far as I know everything is done

[disksing]

All done. Thank you to all who participated!