Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

session: set process info before building plan (#22101) #22148

Merged
merged 6 commits into from
Jan 26, 2021
Merged

session: set process info before building plan (#22101) #22148

merged 6 commits into from
Jan 26, 2021

Conversation

ti-srebot
Copy link
Contributor

cherry-pick #22101 to release-4.0

What problem does this PR solve?

Issue Number: close #22068

Problem Summary:
Uncorrelated subqueries will execute once when building plan, and it maybe cost much time. So we set process info before building plan, to trace the running time and info.

What is changed and how it works?

Proposal: xxx

What's Changed:

How it Works:

Related changes

  • Need to cherry-pick to the release branch 4.0,5.0

Check List

Tests

  • Manual test (add detailed scripts or steps below)
    Session 1:
    select 1 from t where a = (select sleep(30));
    Session 2:
[tidb]> show processlist;
+------+------+-----------+------+---------+------+------------+----------------------------------------------+
| Id   | User | Host      | db   | Command | Time | State      | Info                                         |
+------+------+-----------+------+---------+------+------------+----------------------------------------------+
|    3 | root | 127.0.0.1 | test | Query   |    6 | autocommit | select 1 from t where a = (select sleep(30)) |
|    5 | root | 127.0.0.1 | NULL | Query   |    0 | autocommit | show processlist                             |
+------+------+-----------+------+---------+------+------------+----------------------------------------------+
2 rows in set (0.000 sec)

Side effects

Release note

  • Show process info when building plan.

@wshwsh12 @ti-srebot
cherry pick pingcap#22101 to release-4.0
05c8772 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-srebot ti-srebot mentioned this pull request Jan 4, 2021
Merged
@ti-srebot ti-srebot added this to the v4.0.9 milestone Jan 4, 2021
@ti-srebot
Copy link
Contributor Author

@wshwsh12 you're already a collaborator in bot's repo.

@github-actions github-actions bot added the sig/sql-infra SIG: SQL Infra label Jan 7, 2021
@jebter jebter modified the milestones: v4.0.9, v4.0.10 Jan 7, 2021
@jebter jebter modified the milestones: v4.0.10, v4.0.11 Jan 18, 2021
qw4990
qw4990 reviewed Jan 25, 2021
View reviewed changes
Copy link
Contributor

@qw4990 qw4990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot
Copy link
Contributor Author

@qw4990, Thanks for your review. The bot only counts LGTMs from Reviewers and higher roles, but you're still welcome to leave your comments. See the corresponding SIG page for more information. Related SIG: sql-infra(slack).

@qw4990 qw4990 added status/PTAL and removed sig/sql-infra SIG: SQL Infra labels Jan 25, 2021
qw4990
qw4990 reviewed Jan 25, 2021
View reviewed changes
Copy link
Contributor

@qw4990 qw4990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Jan 25, 2021
@qw4990
Copy link
Contributor

qw4990 commented Jan 25, 2021

PTAL @XuHuaiyu @lzmhhh123

zz-jason
zz-jason previously approved these changes Jan 25, 2021
View reviewed changes
@ti-srebot ti-srebot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jan 25, 2021
@github-actions github-actions bot added the sig/sql-infra SIG: SQL Infra label Jan 25, 2021
@zz-jason
Copy link
Member

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Jan 25, 2021
@ti-srebot
Copy link
Contributor Author

Your auto merge job has been accepted, waiting for:

  • 20981
  • 21323
  • 21329
  • 21404
  • 21443
  • 21473
  • 21477
  • 21582
  • 21593
  • 21602
  • 21604
  • 21610
  • 21623
  • 21635
  • 21958
  • 22116

@qw4990
Copy link
Contributor

qw4990 commented Jan 26, 2021

@wshwsh12 Please resolve conflicts.

@ti-srebot
Copy link
Contributor Author

@qw4990, Thanks for your review. The bot only counts LGTMs from Reviewers and higher roles, but you're still welcome to leave your comments. See the corresponding SIG page for more information. Related SIG: sql-infra(slack).

@qw4990
Copy link
Contributor

qw4990 commented Jan 26, 2021

/merge

@ti-srebot
Copy link
Contributor Author

Your auto merge job has been accepted, waiting for:

  • 21628
  • 21142
  • 21936
  • 21874
  • 20981
  • 21464
  • 21483
  • 21525
  • 21590
  • 21604
  • 21614
  • 21673
  • 21697
  • 21810
  • 22527

@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-srebot
Copy link
Contributor Author

/run-all-tests

@qw4990
Copy link
Contributor

qw4990 commented Jan 26, 2021

/merge

1 similar comment
@qw4990
Copy link
Contributor

qw4990 commented Jan 26, 2021

/merge

@ti-srebot
Copy link
Contributor Author

Your auto merge job has been accepted, waiting for:

  • 21945
  • 22136
  • 22119
  • 21853
  • 22174
  • 21881
  • 22527
  • 22527

@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-srebot ti-srebot merged commit 6d0ffe4 into pingcap:release-4.0 Jan 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qw4990 qw4990 qw4990 approved these changes

@lzmhhh123 lzmhhh123 Awaiting requested review from lzmhhh123

@XuHuaiyu XuHuaiyu Awaiting requested review from XuHuaiyu

@zz-jason zz-jason Awaiting requested review from zz-jason

Assignees

@wshwsh12 wshwsh12

Labels
sig/sql-infra SIG: SQL Infra status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug. type/4.0-cherry-pick
Projects
None yet
Milestone
v4.0.11
Development

Successfully merging this pull request may close these issues.
5 participants
@ti-srebot @qw4990 @zz-jason @jebter @wshwsh12