Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

session: set process info before building plan #22101

Merged
merged 7 commits into from
Jan 4, 2021

Conversation

wshwsh12
Copy link
Contributor

@wshwsh12 wshwsh12 commented Dec 30, 2020

What problem does this PR solve?

Issue Number: close #22068

Problem Summary:
Uncorrelated subqueries will execute once when building plan, and it maybe cost much time. So we set process info before building plan, to trace the running time and info.

What is changed and how it works?

Proposal: xxx

What's Changed:

How it Works:

Related changes

  • Need to cherry-pick to the release branch 4.0,5.0

Check List

Tests

  • Manual test (add detailed scripts or steps below)
    Session 1:
    select 1 from t where a = (select sleep(30));
    Session 2:
[tidb]> show processlist;
+------+------+-----------+------+---------+------+------------+----------------------------------------------+
| Id   | User | Host      | db   | Command | Time | State      | Info                                         |
+------+------+-----------+------+---------+------+------------+----------------------------------------------+
|    3 | root | 127.0.0.1 | test | Query   |    6 | autocommit | select 1 from t where a = (select sleep(30)) |
|    5 | root | 127.0.0.1 | NULL | Query   |    0 | autocommit | show processlist                             |
+------+------+-----------+------+---------+------+------------+----------------------------------------------+
2 rows in set (0.000 sec)

Side effects

Release note

  • Show process info when building plan.

@sre-bot
Copy link
Contributor

sre-bot commented Dec 30, 2020

@ichn-hu ichn-hu mentioned this pull request Dec 30, 2020
Copy link
Contributor

@lzmhhh123 lzmhhh123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Dec 31, 2020
@wshwsh12 wshwsh12 requested a review from XuHuaiyu January 4, 2021 02:15
@XuHuaiyu XuHuaiyu added the type/bugfix This PR fixes a bug. label Jan 4, 2021
Copy link
Contributor

@XuHuaiyu XuHuaiyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot removed the status/LGT1 Indicates that a PR has LGTM 1. label Jan 4, 2021
@ti-srebot ti-srebot added the status/LGT2 Indicates that a PR has LGTM 2. label Jan 4, 2021
@XuHuaiyu
Copy link
Contributor

XuHuaiyu commented Jan 4, 2021

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Jan 4, 2021
@ti-srebot
Copy link
Contributor

Your auto merge job has been accepted, waiting for:

  • 21911

@ti-srebot
Copy link
Contributor

/run-all-tests

@wshwsh12
Copy link
Contributor Author

wshwsh12 commented Jan 4, 2021

/merge

@ti-srebot
Copy link
Contributor

/run-all-tests

@ti-srebot
Copy link
Contributor

@wshwsh12 merge failed.

@wshwsh12
Copy link
Contributor Author

wshwsh12 commented Jan 4, 2021

/merge

@ti-srebot
Copy link
Contributor

/run-all-tests

@ti-srebot ti-srebot merged commit 57cd694 into pingcap:master Jan 4, 2021
ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Jan 4, 2021
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Contributor

cherry pick to release-4.0 in PR #22148

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Jan 4, 2021
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Contributor

cherry pick to release-5.0-rc in PR #22149

ti-srebot added a commit that referenced this pull request Jan 26, 2021
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

show processlist can not display the running query with subquery
5 participants