infoschema: improve test stability in other timezones #20704
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
ghost
requested a review
from 
|
/run-all-tests |
|
LGTM |
ti-srebot
approved these changes
Nov 3, 2020
|
/merge |
ti-srebot
added
the
status/can-merge
|
/run-all-tests |
|
@nullnotnil merge failed. |
|
/run-integration-compatibility-test |
|
/merge |
|
Your auto merge job has been accepted, waiting for:
|
|
/run-all-tests |
|
@nullnotnil merge failed. |
ti-srebot
added
status/LGT3
AilinKid
approved these changes
Nov 3, 2020
|
/run-check_dev_2 |
|
/merge |
|
/run-all-tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
This improves stability of information_schema tests when run in Timezones outside of China.
Problem Summary:
The type of
cluster_slow_query.Timeis a timestamp, which has the semantics of converting from the current timestamp to UTC before comparing to the value in storage. The test-suite previously did not explicitly set the timestamp, which lead to an ambiguous comparision:I have seen this fail inconsistently (i.e. it's only flaky: not a failing test). I think the reason might be because the test-suite runs in parallel. See
TestSlowQuery()which sets the timezone for consistency, butTestSelectClusterTable()does not.This instability was introduced in #19938
What is changed and how it works?
What's Changed:
Improvements to test stability.
Related changes
Check List
Tests
Side effects
Release note