Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

executor: fix cluster_slow_query time type in streaming request bug #19938

Merged
merged 4 commits into from
Sep 11, 2020
Merged

executor: fix cluster_slow_query time type in streaming request bug #19938

merged 4 commits into from
Sep 11, 2020

Conversation

crazycs520
Copy link
Contributor

What problem does this PR solve?

close #19937

What is changed and how it works?

The TIME column type of cluster_slow_query was wrong.

Related changes

  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test

Side effects

  • No

Release note

  • Fix issue querying cluster_slow_query time type in streaming request bug.

@crazycs520
executor: fix slow_query time type in streaming request bug
f0d03ba 
Signed-off-by: crazycs520 <crazycs520@gmail.com>
@crazycs520
add test
ca56605 
Signed-off-by: crazycs520 <crazycs520@gmail.com>
@crazycs520 crazycs520 requested a review from a team as a code owner September 10, 2020 12:30
@crazycs520 crazycs520 requested review from lzmhhh123 and removed request for a team September 10, 2020 12:30
@github-actions github-actions bot added sig/sql-infra SIG: SQL Infra sig/execution SIG execution labels Sep 10, 2020
@crazycs520
Copy link
Contributor Author

/run-all-tests

@crazycs520 crazycs520 added type/bugfix This PR fixes a bug. and removed sig/sql-infra SIG: SQL Infra labels Sep 10, 2020
AilinKid
AilinKid reviewed Sep 10, 2020
View reviewed changes
Copy link
Contributor

@AilinKid AilinKid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Sep 10, 2020
@github-actions github-actions bot added the sig/sql-infra SIG: SQL Infra label Sep 10, 2020
tangenta
tangenta reviewed Sep 11, 2020
View reviewed changes
Copy link
Contributor

@tangenta tangenta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot removed the status/LGT1 Indicates that a PR has LGTM 1. label Sep 11, 2020
@ti-srebot ti-srebot added the status/LGT2 Indicates that a PR has LGTM 2. label Sep 11, 2020
@crazycs520
Copy link
Contributor Author

/run-all-tests

@crazycs520 crazycs520 merged commit f13d605 into pingcap:master Sep 11, 2020
@breezewish
Copy link
Member

need cherry pick?

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Sep 11, 2020
@crazycs520 @ti-srebot
cherry pick pingcap#19938 to release-4.0
e9e254d 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Sep 11, 2020
Merged
@ti-srebot
Copy link
Contributor

cherry pick to release-4.0 in PR #19943

bb7133 pushed a commit that referenced this pull request Sep 16, 2020
@ti-srebot
executor: fix cluster_slow_query time type in streaming request bug (#…
daf2656 
…19938) (#19943)
@ghost ghost mentioned this pull request Oct 28, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AilinKid AilinKid AilinKid left review comments

@tangenta tangenta tangenta left review comments

@ti-srebot ti-srebot ti-srebot approved these changes

@lzmhhh123 lzmhhh123 Awaiting requested review from lzmhhh123

Assignees
No one assigned
Labels
sig/execution SIG execution sig/sql-infra SIG: SQL Infra status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

query CLUSTER_SLOW_QUERY return wrong time.
5 participants
@crazycs520 @breezewish @ti-srebot @AilinKid @tangenta