Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

executor: fix unexpected results when do index merge join on outer join #20581

Merged
merged 5 commits into from
Nov 10, 2020
Merged

executor: fix unexpected results when do index merge join on outer join #20581

Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
41a78fb
executor: fix unexpected index merge join results for outer join
lzmhhh123 Oct 22, 2020
08b1477
add test
lzmhhh123 Oct 22, 2020
5cc5b41
move integration test to tidb-test
lzmhhh123 Oct 22, 2020
59baed2
address comment
lzmhhh123 Oct 30, 2020
a4b012a
Merge branch 'master' into bug-fix/fix_outer_join_index_merge
ti-srebot Nov 10, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions executor/index_lookup_merge_join.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -558,6 +558,9 @@ func (imw *innerMergeWorker) doMergeJoin(ctx context.Context, task *lookUpMergeJ
hasMatch, hasNull, cmpResult := false, false, initCmpResult
// If it has iterated out all inner rows and the inner rows with same key is empty,
// that means the outer row needn't match any inner rows.
if task.outerMatch != nil && !task.outerMatch[outerIdx.ChkIdx][outerIdx.RowIdx] {
lzmhhh123 marked this conversation as resolved.
Show resolved Hide resolved
goto missMatch
}
if noneInnerRowsRemain && len(task.sameKeyInnerRows) == 0 {
goto missMatch
}
Expand Down