Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

executor: fix unexpected results when do index merge join on outer join #20581

Merged
merged 5 commits into from
Nov 10, 2020
Merged

executor: fix unexpected results when do index merge join on outer join #20581

merged 5 commits into from
Nov 10, 2020

Conversation

lzmhhh123
Copy link
Contributor

@lzmhhh123 lzmhhh123 commented Oct 22, 2020 •
edited by SunRunAway
Loading

What problem does this PR solve?

Issue Number: close #20571, close #20953

What is changed and how it works?

How it Works: filter outer rows in do merge join

Related changes

  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test
  • Integration test

Side effects

  • Performance regression
    • Consumes more CPU

Release note

  • fix unexpected results when do merge join on outer join

@lzmhhh123 lzmhhh123 added type/bugfix This PR fixes a bug. sig/execution SIG execution needs-cherry-pick-4.0 labels Oct 22, 2020
@lzmhhh123 lzmhhh123 requested a review from a team as a code owner October 22, 2020 06:25
@lzmhhh123
Copy link
Contributor Author

/run-all-tests

@zz-jason zz-jason changed the title executor: fix unexpected results when do merge join on outer join executor: fix unexpected results when do index merge join on outer join Oct 22, 2020
zz-jason
zz-jason reviewed Oct 22, 2020
View reviewed changes
Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please write the integration test to tidb-test.

@lzmhhh123
Copy link
Contributor Author

/run-check_dev_2
/run-unit-test

@lzmhhh123
Copy link
Contributor Author

/run-all-tests tidb-test=pr/1094

@lzmhhh123
Copy link
Contributor Author

/run-common-test tidb-test=pr/1094
/run-integration-common-test tidb-test=pr/1094

@lzmhhh123
Copy link
Contributor Author

/run-common-test tidb-test=pr/1094
/run-integration-common-test tidb-test=pr/1094
/run-unit-test

@lzmhhh123
Copy link
Contributor Author

/run-unit-test

@lzmhhh123
Copy link
Contributor Author

/cc @ichn-hu

@wjhuang2016
Copy link
Member

Could you make the PR description more clearer? What's the root cause?

@lzmhhh123
Copy link
Contributor Author

/cc @ichn-hu

@ichn-hu ichn-hu mentioned this pull request Nov 3, 2020
Closed
XuHuaiyu
XuHuaiyu approved these changes Nov 10, 2020
View reviewed changes
Copy link
Contributor

@XuHuaiyu XuHuaiyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 10, 2020
ichn-hu
ichn-hu approved these changes Nov 10, 2020
View reviewed changes
Copy link
Contributor

@ichn-hu ichn-hu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot removed the status/LGT1 Indicates that a PR has LGTM 1. label Nov 10, 2020
@ti-srebot ti-srebot added the status/LGT2 Indicates that a PR has LGTM 2. label Nov 10, 2020
@lzmhhh123
Copy link
Contributor Author

/merge

@ti-srebot
Copy link
Contributor

Your auto merge job has been accepted, waiting for:

  • 20935

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Nov 10, 2020
@ti-srebot
Copy link
Contributor

/run-all-tests

@lzmhhh123 lzmhhh123 linked an issue Nov 10, 2020 that may be closed by this pull request
Unexpected result of MySQL test with Index Merge Join hint #20953
Closed
@ti-srebot
Copy link
Contributor

@lzmhhh123 merge failed.

@lzmhhh123 lzmhhh123 merged commit 658a4ce into pingcap:master Nov 10, 2020
@lzmhhh123 lzmhhh123 deleted the bug-fix/fix_outer_join_index_merge branch November 10, 2020 06:25
ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Nov 10, 2020
@lzmhhh123 @ti-srebot
cherry pick pingcap#20581 to release-4.0
259666e 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Nov 10, 2020
Merged
@ti-srebot
Copy link
Contributor

cherry pick to release-4.0 in PR #20954

lzmhhh123 added a commit to SunRunAway/tidb that referenced this pull request Nov 10, 2020
@lzmhhh123
executor: fix unexpected results when do index merge join on outer jo…
f2701b6 
…in (pingcap#20581)
ti-srebot added a commit that referenced this pull request Nov 13, 2020
@ti-srebot
executor: fix unexpected results when do index merge join on outer jo…
c05d221 
…in (#20581) (#20954)

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zz-jason zz-jason zz-jason left review comments

@XuHuaiyu XuHuaiyu XuHuaiyu approved these changes

@ichn-hu ichn-hu ichn-hu approved these changes

@ti-srebot ti-srebot ti-srebot approved these changes

@SunRunAway SunRunAway Awaiting requested review from SunRunAway

Assignees
No one assigned
Labels
sig/execution SIG execution status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unexpected result of MySQL test with Index Merge Join hint delete unrelated column has different results
6 participants
@lzmhhh123 @wjhuang2016 @ti-srebot @zz-jason @XuHuaiyu @ichn-hu