executor: clean outerMatchedStatus when HashJoin.Close is called #19510
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wshwsh12
requested review from
SunRunAway,
XuHuaiyu and
fzhedu
and removed request for
a team
wshwsh12
added
sig/execution
|
LGTM |
|
the release note is hard to understand for a user, could you elaborate more on how the bug is triggered in the release note? |
ti-srebot
added
status/LGT2
ti-srebot
previously approved these changes
Aug 28, 2020
|
/merge |
ti-srebot
added
the
status/can-merge
|
/run-all-tests |
|
/merge |
|
/run-all-tests |
|
@wshwsh12 merge failed. |
|
/run-all-tests |
|
/run-integration-copr-test |
XuHuaiyu
approved these changes
Aug 31, 2020
ti-srebot
pushed a commit
to ti-srebot/tidb
that referenced
this pull request
Aug 31, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
|
cherry pick to release-4.0 in PR #19611 |
zz-jason
pushed a commit
that referenced
this pull request
Sep 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #19500
Problem Summary: outerMatchedStatus is not cleaned, and use by the next call.
What is changed and how it works?
Proposal: xxx
What's Changed: Clean outerMatchedStatus when HashJoin.Close is called
How it Works:
Related changes
Check List
Tests
Side effects
Release note