Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

executor: clean outerMatchedStatus when HashJoin.C ... (#19510) #19611

Merged
merged 6 commits into from
Sep 1, 2020

Conversation

ti-srebot
Copy link
Contributor

cherry-pick #19510 to release-4.0


What problem does this PR solve?

Issue Number: close #19500

Problem Summary: outerMatchedStatus is not cleaned, and use by the next call.

What is changed and how it works?

Proposal: xxx

What's Changed: Clean outerMatchedStatus when HashJoin.Close is called

How it Works:

Related changes

  • Need to cherry-pick to the release branch 4.0

Check List

Tests

  • Unit test
  • Integration test

Side effects

Release note

  • Fix an query error when there is an Apply upon HashJoin

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Contributor Author

/run-all-tests

Copy link
Contributor

@XuHuaiyu XuHuaiyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 31, 2020
zz-jason
zz-jason previously approved these changes Sep 1, 2020
Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Sep 1, 2020
@zz-jason
Copy link
Member

zz-jason commented Sep 1, 2020

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Sep 1, 2020
@ti-srebot
Copy link
Contributor Author

Your auto merge job has been accepted, waiting for:

  • 18801
  • 19445
  • 19518
  • 19452
  • 19439
  • 19465
  • 19628

@zz-jason
Copy link
Member

zz-jason commented Sep 1, 2020

/merge

@ti-srebot
Copy link
Contributor Author

Your auto merge job has been accepted, waiting for:

  • 18696
  • 18760
  • 19215
  • 19454
  • 18801
  • 19445
  • 19452
  • 19439
  • 19465

@zz-jason
Copy link
Member

zz-jason commented Sep 1, 2020

/merge

@ti-srebot
Copy link
Contributor Author

Your auto merge job has been accepted, waiting for:

  • 19465
  • 19577
  • 19559
  • 19614
  • 19049
  • 18997
  • 18696
  • 18760
  • 19215
  • 19454
  • 18801
  • 19445
  • 19452
  • 19465
  • 19601

@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-srebot
Copy link
Contributor Author

@ti-srebot merge failed.

@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-srebot
Copy link
Contributor Author

@ti-srebot merge failed.

@zz-jason
Copy link
Member

zz-jason commented Sep 1, 2020

/merge

@ti-srebot
Copy link
Contributor Author

Your auto merge job has been accepted, waiting for:

  • 19559
  • 19614
  • 19049
  • 18997
  • 18696
  • 18760
  • 19215
  • 19454
  • 19601
  • 18801
  • 18696
  • 18760
  • 19049
  • 19452
  • 19454
  • 19465
  • 19559
  • 19601

@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-srebot
Copy link
Contributor Author

@ti-srebot merge failed.

@zz-jason zz-jason changed the title executor: clean outerMatchedStatus when HashJoin.Close is called (#19510) executor: clean outerMatchedStatus when HashJoin.C ... (#19510) Sep 1, 2020
@zz-jason zz-jason merged commit 00c6a4a into pingcap:release-4.0 Sep 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig/execution SIG execution status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug. type/4.0-cherry-pick
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants