Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

session: fix a bug that upgrading from 3.1.1 to 4.0 fails (#17293) #17300

Merged
merged 1 commit into from
May 20, 2020

Conversation

sre-bot
Copy link
Contributor

@sre-bot sre-bot commented May 19, 2020

cherry-pick #17293 to release-4.0


What problem does this PR solve?

Issue Number: close #17292

Problem Summary:
The server version 39 in v3.1.1 is not consistent with v4.0+

What is changed and how it works?

Add a new server version 46, and redo version 39.

Related changes

  • Need to cherry-pick to the release branch

Check List

Tests

  • Manual test (add detailed scripts or steps below)
    git checkout v3.1.1
    make && run
    exit
    git checkout this_pr
    make && run
    success

Side effects

Release note

  • fix a bug that upgrading from 3.1.1 to 4.0 fails

@sre-bot
Copy link
Contributor Author

sre-bot commented May 19, 2020

/run-all-tests

Copy link
Member

@bb7133 bb7133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@lysu lysu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jebter
Copy link

jebter commented May 20, 2020

/merge

@sre-bot sre-bot added the status/can-merge Indicates a PR has been approved by a committer. label May 20, 2020
@sre-bot
Copy link
Contributor Author

sre-bot commented May 20, 2020

/run-all-tests

@sre-bot sre-bot merged commit 9432ebb into pingcap:release-4.0 May 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/can-merge Indicates a PR has been approved by a committer. type/bugfix This PR fixes a bug. type/4.0-cherry-pick
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants